Add metadata support for TPC #27628
Merged
Add metadata support for TPC #27628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
reviewed
Mar 14, 2022
| /// </summary> | ||
| /// <param name="entityType">The entity type.</param> | ||
| /// <returns>The mapping strategy for the derived types.</returns> | ||
| public static string? GetMappingStrategy(this IReadOnlyEntityType entityType) |
There was a problem hiding this comment.
Can a mapping strategy be applied to the entire model rather than to each entity type?
ajcvickers
reviewed
Mar 14, 2022
ajcvickers
approved these changes
Mar 14, 2022
Part of #3170
smitpatel
reviewed
Mar 17, 2022
What would happen in scenario when user configures discriminator and also applies TPT/TPC mapping strategy explicitly? Refers to: src/EFCore.Relational/Metadata/Conventions/EntityTypeHierarchyMappingConvention.cs:110 in db75fae. [](commit_id = db75fae, deletion_comment = False) |
smitpatel
reviewed
Mar 17, 2022
| { | ||
| var columnName = property.GetColumnBaseName(); | ||
| if (columnName == null) | ||
| var mappedTableName = isTph ? entityType.GetRootType().Name : mappedType.Name; |
There was a problem hiding this comment.
Would have loved if the variable didn't use table in the name.
smitpatel
reviewed
Mar 17, 2022
smitpatel
reviewed
Mar 17, 2022
smitpatel
reviewed
Mar 17, 2022
smitpatel
reviewed
Mar 17, 2022
smitpatel
reviewed
Mar 17, 2022
We throw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3170
UseTpcMappingStrategyandUseTptMappingStrategy, calling either maps all derived to different tables/viewsToTableon a non-root type maps the hierarchy using TPTToTableon abstract entity type if TPC