Update to .NET SDK 7.0 Preview 2 #27447

bricelam · 2022-02-15T18:31:29Z

~~Still waiting for the official release, so the version number may change again before I merge, but this one is close.~~

bricelam · 2022-02-15T18:33:37Z

@dotnet/efteam Should we update our tests (and benchmarks) to run on net7.0 or wait?

bricelam · 2022-02-15T19:41:46Z

Looks like there are a few failures in the analyzers tests.

The collection was expected to contain a single element

test/EFCore.Analyzers.Tests/UninitializedDbSetDiagnosticSuppressorTest.cs

bricelam · 2022-02-16T17:05:56Z

Hmm, looks like there's some failure around Trimming now...

roji · 2022-02-24T13:12:52Z

Huh? Tried to fix the trimming by running the resulting executable from the right directory (net7.0 instead of net6.0), now there's a new test failure on AddressAndPayment_RedirectToCompleteWhenSuccessful ⁉️

bricelam · 2022-02-28T22:22:03Z

@maumar, do you want to dig into the MusicStoreInMemoryTest.AddressAndPayment_RedirectToCompleteWhenSuccessful failure?

Assert.Equal() Failure
Expected: 0
Actual:   (null)

bricelam · 2022-02-28T22:24:38Z

And now there's a new exception being thrown from System.Text.Json.

TypeLoadException : Could not load type 'System.Runtime.CompilerServices.Unsafe' from assembly 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
   at System.Text.Json.JsonReaderHelper.IndexOfOrLessThan(Byte& searchSpace, Byte value0, Byte value1, Byte lessThan, Int32 length)
   at System.Text.Json.Utf8JsonReader.ConsumeString()
   at System.Text.Json.Utf8JsonReader.ConsumePropertyName()
   at System.Text.Json.Utf8JsonReader.ReadSingleSegment()

bricelam · 2022-02-28T22:27:31Z

@Pilchie Is the Json exception a known issue?

Pilchie · 2022-02-28T22:31:04Z

Not known to me. @danmoseley - any ideas?

Pilchie · 2022-02-28T23:12:12Z

@dotnet/aspnet-build - any of you seen this in .NET 7 builds?

wtgodbe · 2022-02-28T23:32:06Z

Looks like you might be building one version of the runtime while running against another - there may be other net6.0 TFMs to update. I see it's referenced in 51 files but this PR only touches 41: https://github.com/dotnet/efcore/search?q=net6.0

ajcvickers · 2022-03-01T10:00:30Z

@wtgodbe We still want to target .NET 6 with our product assemblies, but we want our tests to use .NET 7. (Ideally, we won't target .NET 7 even when we ship RTM since that forces people off an LTS framework, which many people don't want to do.)

Pilchie · 2022-03-01T15:53:40Z

Just saw dotnet/aspnetcore#40471 from @jkotas which looks like it might be related?

jkotas · 2022-03-01T16:03:02Z

Just saw dotnet/aspnetcore#40471 from @jkotas which looks like it might be related?

Yes, it is related, but I do not think it is the root cause of the build break. The change that removed S.R.CS.Unsafe package in dotnet/runtime is not included in .NET 7 preview1. If you see build breaks due to do this package removal, you are mixing .NET 7 preview1 bits with some newer bits. It is not unusual to see intra-release breaking changes in previews like this one. Mixing bits from different previews will expose you to the intra-release breaking changes like that.

bricelam · 2022-03-01T19:15:20Z

Thanks! We typically only hit a few of these breaks each release. We find that saying on released previews of the SDK and runtime helps contributors immensely since they don't have to worry about setting environment variables before launching their IDE.

I'll pin a few packages to their Preview 1 versions for now. If this continues to be a problem, we can consider flowing the runtime again (at the expense of productivity and contributors).

bricelam · 2022-03-01T19:29:52Z

@maumar Looks like SQL Server and SQLite are now failing with the same error.

maumar · 2022-03-08T00:10:20Z

@bricelam AddressAndPayment_RedirectToCompleteWhenSuccessful also happens due to

'Could not load type 'System.Runtime.CompilerServices.Unsafe' from assembly 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.'

maumar · 2022-03-11T21:16:23Z

@bricelam

Could not load type 'System.Runtime.CompilerServices.Unsafe' from assembly 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.":"System.Runtime.CompilerServices.Unsafe"

   at Microsoft.Extensions.Primitives.StringValues.get_Count()
   at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Boolean& found)
   at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source)
   at Microsoft.EntityFrameworkCore.MusicStoreTestBase`1.CheckoutController.<AddressAndPayment>d__3.MoveNext() in

ghost · 2022-03-15T21:40:16Z

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost · 2022-03-15T21:53:35Z

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

bricelam · 2022-03-15T22:43:33Z

New failures in EFCore.OData.FunctionalTests after updating to Preview 2.

smitpatel · 2022-03-17T22:44:11Z

System.Net.Http.HttpRequestException : An error occurred while sending the request.
---- System.IO.IOException : The response ended prematurely.

bricelam · 2022-03-18T16:05:42Z

Yep. That's the one.

@maumar Would it be possible (without a ton of infrastructure) to show the server-side errors on failure?

maumar · 2022-03-22T19:18:07Z

@bricelam OData tests fail due to:

Could not load type 'System.Runtime.CompilerServices.Unsafe' from assembly 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1Connection.EnsureHostHeaderExists()
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1Connection.TryParseRequest(ReadResult result, Boolean& endConnection)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequestsAsync[TContext](IHttpApplication`1 application)
Exception thrown: 'System.Net.Http.HttpRequestException' in System.Private.CoreLib.dll

smitpatel · 2022-03-23T18:50:47Z

eng/Versions.props

-    <MicrosoftExtensionsConfigurationAbstractionsVersion>7.0.0-preview.3.22171.1</MicrosoftExtensionsConfigurationAbstractionsVersion>
-    <MicrosoftExtensionsConfigurationEnvironmentVariablesVersion>7.0.0-preview.3.22171.1</MicrosoftExtensionsConfigurationEnvironmentVariablesVersion>
-    <MicrosoftExtensionsConfigurationJsonVersion>7.0.0-preview.3.22171.1</MicrosoftExtensionsConfigurationJsonVersion>
+    <SystemCollectionsImmutableVersion>7.0.0-preview.2.22152.2</SystemCollectionsImmutableVersion>


With this change we have downgraded our dependencies in main branch. Is that required? Do we need to get main to upgrade dependencies again?
cc: @dotnet/aspnet-build

Will unpin once we upgrade to Preview 3 of the SDK (see conversation above)

bricelam added the blocked label Feb 15, 2022

bricelam requested a review from a team February 15, 2022 18:31

bricelam force-pushed the 70p1 branch from 993034d to 82b0302 Compare February 15, 2022 21:27

roji approved these changes Feb 15, 2022

View reviewed changes

test/EFCore.Analyzers.Tests/UninitializedDbSetDiagnosticSuppressorTest.cs Outdated Show resolved Hide resolved

bricelam removed the blocked label Feb 28, 2022

bricelam force-pushed the 70p1 branch from 0390348 to 27e9880 Compare February 28, 2022 21:41

bricelam force-pushed the 70p1 branch from 27e9880 to 26a3ca0 Compare March 1, 2022 19:29

bricelam requested a review from dougbu as a code owner March 1, 2022 19:29

roji mentioned this pull request Mar 8, 2022

Tiny workaround for analyzer issue #27591

Merged

bricelam force-pushed the 70p1 branch from 26a3ca0 to 0e37a05 Compare March 15, 2022 21:38

bricelam changed the title ~~Update to .NET SDK 7.0 Preview 1~~ Update to .NET SDK 7.0 Preview 2 Mar 15, 2022

bricelam added the auto-merge label Mar 15, 2022

bricelam force-pushed the 70p1 branch 2 times, most recently from 789d401 to 2696b36 Compare March 22, 2022 22:42

bricelam and others added 3 commits March 23, 2022 10:42

⬆️ Update to .NET SDK 7.0-preview.2

2d00234

Run tests on .NET 7

2e3c79c

Execute trimming tests from the right path

e112653

bricelam force-pushed the 70p1 branch from 2696b36 to e112653 Compare March 23, 2022 17:43

bricelam merged commit e112653 into dotnet:main Mar 23, 2022

bricelam deleted the 70p1 branch March 23, 2022 17:43

smitpatel reviewed Mar 23, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to .NET SDK 7.0 Preview 2 #27447

Update to .NET SDK 7.0 Preview 2 #27447

bricelam commented Feb 15, 2022 •

edited

Loading

bricelam commented Feb 15, 2022 •

edited

Loading

bricelam commented Feb 15, 2022

bricelam commented Feb 16, 2022

roji commented Feb 24, 2022

bricelam commented Feb 28, 2022

bricelam commented Feb 28, 2022 •

edited

Loading

bricelam commented Feb 28, 2022

Pilchie commented Feb 28, 2022

Pilchie commented Feb 28, 2022

wtgodbe commented Feb 28, 2022

ajcvickers commented Mar 1, 2022

Pilchie commented Mar 1, 2022

jkotas commented Mar 1, 2022

bricelam commented Mar 1, 2022

bricelam commented Mar 1, 2022

maumar commented Mar 8, 2022

maumar commented Mar 11, 2022

ghost commented Mar 15, 2022

ghost commented Mar 15, 2022

From the bot dev team

bricelam commented Mar 15, 2022

smitpatel commented Mar 17, 2022

bricelam commented Mar 18, 2022

maumar commented Mar 22, 2022

smitpatel Mar 23, 2022

bricelam Mar 23, 2022 •

edited

Loading

Update to .NET SDK 7.0 Preview 2 #27447

Update to .NET SDK 7.0 Preview 2 #27447

Conversation

bricelam commented Feb 15, 2022 • edited Loading

bricelam commented Feb 15, 2022 • edited Loading

bricelam commented Feb 15, 2022

bricelam commented Feb 16, 2022

roji commented Feb 24, 2022

bricelam commented Feb 28, 2022

bricelam commented Feb 28, 2022 • edited Loading

bricelam commented Feb 28, 2022

Pilchie commented Feb 28, 2022

Pilchie commented Feb 28, 2022

wtgodbe commented Feb 28, 2022

ajcvickers commented Mar 1, 2022

Pilchie commented Mar 1, 2022

jkotas commented Mar 1, 2022

bricelam commented Mar 1, 2022

bricelam commented Mar 1, 2022

maumar commented Mar 8, 2022

maumar commented Mar 11, 2022

ghost commented Mar 15, 2022

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost commented Mar 15, 2022

From the bot dev team

bricelam commented Mar 15, 2022

smitpatel commented Mar 17, 2022

bricelam commented Mar 18, 2022

maumar commented Mar 22, 2022

smitpatel Mar 23, 2022

Choose a reason for hiding this comment

bricelam Mar 23, 2022 • edited Loading

Choose a reason for hiding this comment

bricelam commented Feb 15, 2022 •

edited

Loading

bricelam commented Feb 15, 2022 •

edited

Loading

bricelam commented Feb 28, 2022 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

bricelam Mar 23, 2022 •

edited

Loading