Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] ModelBuilding: Check for navigation compatibility with keyless type w… #26090

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

smitpatel
Copy link
Member

@smitpatel smitpatel commented Sep 17, 2021

…hen navigation is non-null

Resolves #26073

Description
Configuring relationship from keyless entity using HasOne.WithMany API throws exception message even in valid configuration.

Customer Impact
Customer cannot build a perfectly valid model.

How found
Reported by customer in #26703

Test coverage
Added coverage for affected scenario

Regression?
Yes, from 5.0.

Risk
Low. The fix only avoid throwing exception in incorrect case.

@smitpatel smitpatel changed the title ModelBuilding: Check for navigation compatibility with keyless type w… [6.0] ModelBuilding: Check for navigation compatibility with keyless type w… Sep 17, 2021
@smitpatel
Copy link
Member Author

cc: @Pilchie for approval.

@Pilchie
Copy link
Member

Pilchie commented Sep 17, 2021

Approved for .NET 6.

@smitpatel smitpatel merged commit a70a174 into release/6.0 Sep 17, 2021
@smitpatel smitpatel deleted the smit/abc branch September 17, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.0.0-rc.1.21452.10: Navigations can only target entity types with keys
3 participants