MemberEntry support for skip navigations #21940
Conversation
| /// <summary> | ||
| /// Gets the metadata that describes the facets of this property and how it maps to the database. | ||
| /// </summary> | ||
| public new virtual INavigation Metadata |
There was a problem hiding this comment.
This is a breaking change, but I think it will have minimal impact.
| => Query(navigation, entry); | ||
|
|
||
| private static object[] GetLoadValues(INavigation navigation, InternalEntityEntry entry) | ||
| private static object[] GetLoadValues(INavigationBase navigation, InternalEntityEntry entry) |
There was a problem hiding this comment.
Fixing the loader for skip navigations is next on my list.
| var navigation = Metadata as INavigation; | ||
| var navigationValue = CurrentValue; | ||
|
|
||
| if (Metadata.IsCollection) |
There was a problem hiding this comment.
Move this to CollectionEntry
| && (relatedEntry.EntityState == EntityState.Added | ||
| || relatedEntry.EntityState == EntityState.Deleted | ||
| || (navigation != null | ||
| && navigation.ForeignKey.Properties.Any(relatedEntry.IsModified)))) |
There was a problem hiding this comment.
Shouldn't we also check the state of the join entities for skip navs?
There was a problem hiding this comment.
Yes, good catch. I'm mad at myself because I realized that last night, but apparently by this morning I forgot...
There was a problem hiding this comment.
Don't send out PRs just before community standup 😄
| } | ||
| set | ||
| { | ||
| if (Metadata.IsOnDependent) | ||
| var foreignKey = Metadata is ISkipNavigation skipNavigation | ||
| ? skipNavigation.Inverse.ForeignKey |
There was a problem hiding this comment.
Shouldn't we mark both FKs as modified?
| @@ -213,51 +240,46 @@ public override bool IsModified | |||
| { | |||
There was a problem hiding this comment.
Move this to CollectionEntry
Part of #19003