Update DeleteBehavior.Restrict to not apply when navigations are changed #10941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpete
reviewed
Feb 12, 2018
| @@ -24,59 +24,75 @@ public abstract partial class GraphUpdatesTestBase<TFixture> : IClassFixture<TFi | |||
| protected TFixture Fixture { get; } | |||
|
|
|||
| [ConditionalFact] | |||
| public virtual void Optional_One_to_one_relationships_are_one_to_one() | |||
| public virtual DbUpdateException Optional_One_to_one_relationships_are_one_to_one() | |||
There was a problem hiding this comment.
Why do we return the exception?
There was a problem hiding this comment.
For provider-specific verification.
anpete
approved these changes
Feb 12, 2018
Issue #9703 Restrict now means that EF will never either set an FK to null or perform a cascade delete if an entity is deleted. This is the same as before, although the exception type may change--it's a negative case and we triaged this break as okay. However, if a navigation property is explicitly changed, then the FK associated with that navigation property will still be set to null. This is the change from the previous behavior. This changes some negative cases into positive cases, which was also triaged as okay.
ajcvickers
force-pushed
the
CantTouchThis0210
branch
from
af7dc00 to
5a02b32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9703
Restrict now means that EF will never either set an FK to null or perform a cascade delete if an entity is deleted. This is the same as before, although the exception type may change--it's a negative case and we triaged this break as okay. However, if a navigation property is explicitly changed, then the FK associated with that navigation property will still be set to null. This is the change from the previous behavior. This changes some negative cases into positive cases, which was also triaged as okay.