Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFCore pulls latest packages from dotnet/runtime but LKG shared framework from the SDK #31300

Closed
ericstj opened this issue Jul 18, 2023 · 2 comments
Assignees
Labels
area-infrastructure closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-cleanup
Milestone

Comments

@ericstj
Copy link
Member

ericstj commented Jul 18, 2023

Example where this causes a problem: #31178 (comment)

The packages from dotnet/runtime target the latest build of net8.0 and expect API to be present in the shared framework. EFCore does not set it's tests up to run on the matching build, instead it runs on whatever build was present in the SDK it downloaded.

So we're using packages out of dotnet/runtime build 8.0.0-preview.7.23364.11 which depend on API in the shared framework of the same version, however EFCore is running against a shared framework version 8.0.0-preview.7.23329.8 - which is nearly a month out of date. This is going to create problems whenever we depend on new API added to the shared framework. It just so happened that recently we made a change where every library we built against net8.0 depended upon attributes added to the shared framework.

EFCore should make sure that it acquires the matching runtime and makes it's tests target this runtime. ASPNetCore does something similar cc @wtgodbe

@bricelam bricelam self-assigned this Jul 18, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Jul 18, 2023

@bricelam do you know why we haven't had problems with this before? Was it because pre-8.0, EF updated runtimes/SDKs less frequently/more intentionally?

@bricelam
Copy link
Contributor

I think we just started actually running on .NET 8 with @AndriySvyryd's latest AoT tests.

I'm bringing in the code to do this now (assuming it hasn't changed since 6.0)

bricelam added a commit that referenced this issue Jul 18, 2023
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 18, 2023
bricelam added a commit that referenced this issue Jul 18, 2023
@bricelam bricelam added this to the 8.0.0-preview7 milestone Jul 18, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview7, 8.0.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-cleanup
Projects
None yet
Development

No branches or pull requests

4 participants