Make AddPooledDbContextFactory register DbContext in addition to the and factory

[araxemy]

In #25164 it was suggested that EF Core implicitly registers a scoped DbContext as well when AddDbContextFactory is used, which I thought was a great idea, and it was done in RC1 I think.

But why not do the same thing for AddPooledDbContextFactory too?! I'm using AddPooledDbContextFactory in my project and I was surprised to see that the same thing isn't done in that method as well.

[msallin]

Same situation here. We use AddPooledDbContextFactory in all projects but we also use the EF HealthChecks, which expect the DbContext as ctor parameter. Hence, we also have to call AddDbContextPool<T>.

[aradalvand]

@ajcvickers Hi there, any reason as to why this was removed from 7.0.0? It seems like it would be relatively straightforward and simple to implement.
Thank you.

[ajcvickers]

@aradalvand We had to punt a number of smaller issues. While each in itself would not take a long time, that time quickly adds up. This one is also only sugar--it's easy to obtain the same functionality by registering trice--which makes it lower priority.

[xamir82]

@ajcvickers Hi, could this please be added to the v8 milestone? It doesn't take too much effort to implement but the API is just incomplete without it. Thanks.

[ErikEJ]

@xamir82 the project accepts pull requests 😉

[ajcvickers]

@xamir82

API is just incomplete without it

Can you explain a bit more what you mean by this? To me, this is a bit of sugar that means people who need this don't have to add an extra line of code to register the service they want.

[schmellow]

What would be the most correct workaround here?
Would something like that be enough:

builder.Services.AddPooledDbContextFactory<MyContext>( /* full config here */);
builder.Services.AddScoped<MyContext>(p =>
{
    return p.GetRequiredService<IDbContextFactory<MyContext>>().CreateDbContext();
});

(it does not seem wrong to me judging by basic tests, but maybe i'm missing something)
Or do you have to do full AddDbContextPool round, repeating all the configuration?
Or maybe the other way around, as was suggested in here npgsql/efcore.pg#3375 (comment) ?

[roji]

AddDbContextFactory indeed already registers both IDbContextFactory and DbContext in DI (#25164), but AddPooledDbContextFactory indeed does not - I've opened #35484 to track that.

In the meantime, it should be fine to simply also call AddDbContext() after the call - without passing configuration to it (it should pick up the configuration already passed to AddPooledDbContextFactory):

services
    .AddPooledDbContextFactory<BlogContext>(o => o.UseSqlServer(...))
    .AddDbContext<BlogContext>();

[stevendarby]

@roji why do you need a new issue? I know the title isn't clear but the first post seems quite clear they are asking for this in AddPooledDbContextFactory, after seeing it in AddDbContextFactory. My only concern is things like up-votes get lost when this happens...

[roji]

You're right, I looked at the title and didn't notice that the original post was specifically talking AddPooledDbContextFactory, and that AddDbContextFactory was working fine. I'll reverse the situation.