Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port fix for "Code generation for custom data annotation attributes is broken" #25156

Closed
AndriySvyryd opened this issue Jun 25, 2021 · 0 comments
Closed

Port fix for "Code generation for custom data annotation attributes is broken" #25156

AndriySvyryd opened this issue Jun 25, 2021 · 0 comments
Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-bug
Milestone
5.0.9

Comments

@AndriySvyryd
Copy link
Member

See #25128
@AndriySvyryd AndriySvyryd added this to the 5.0.x milestone Jun 25, 2021
@AndriySvyryd AndriySvyryd self-assigned this Jun 25, 2021
@AndriySvyryd AndriySvyryd modified the milestone: 5.0.x Jun 25, 2021
AndriySvyryd pushed a commit that referenced this issue Jun 29, 2021
@lauxjpn @AndriySvyryd
Fix missing code generation output for custom data annotation attributes
63a681e 
* Fixes missing code generation output for custom data annotation attributes.
* Adds regression tests.

The two regression tests currently skip the assembly build process, because the two custom data annotation attributes do not exist in the generated assembly. If necessary, the `Microsoft.EntityFrameworkCore.Design.Tests` assembly could be added as a reference or additional source code files (containing the attributes) could be added to the build process.

Fixes #25156
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 29, 2021
@AndriySvyryd AndriySvyryd removed their assignment Jun 29, 2021
@AndriySvyryd AndriySvyryd mentioned this issue Jun 29, 2021
Merged
AndriySvyryd pushed a commit that referenced this issue Jun 30, 2021
@lauxjpn @AndriySvyryd
Fix missing code generation output for custom data annotation attributes
c39c4b8 
* Fixes missing code generation output for custom data annotation attributes.
* Adds regression tests.

The two regression tests currently skip the assembly build process, because the two custom data annotation attributes do not exist in the generated assembly. If necessary, the `Microsoft.EntityFrameworkCore.Design.Tests` assembly could be added as a reference or additional source code files (containing the attributes) could be added to the build process.

Fixes #25156
@ajcvickers ajcvickers modified the milestones: 5.0.x, 5.0.8 Jul 11, 2021
@andrerom andrerom mentioned this issue Aug 17, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.8, 5.0.9 Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-bug
Projects
None yet
Milestone
5.0.9
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd