Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly generate expression to read provider-specific types from BufferedDataReader #23104

Closed
smitpatel opened this issue Oct 27, 2020 · 0 comments
Closed

Properly generate expression to read provider-specific types from BufferedDataReader #23104

smitpatel opened this issue Oct 27, 2020 · 0 comments
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported regression Servicing-approved type-bug
Milestone
5.0.1

Comments

@smitpatel
Copy link
Member

xref: efcore/EFCore.SqlServer.HierarchyId#24

Rather than passing SqlBytes to the converter, we pass object when using buffering data reader. Buffering data reader should match up type correctly.
@smitpatel smitpatel self-assigned this Oct 27, 2020
@ajcvickers ajcvickers added this to the 6.0.0 milestone Oct 30, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 12, 2020
smitpatel added a commit that referenced this issue Nov 12, 2020
@smitpatel
Query: Properly generate expression to read from BufferedDataReader
2033f65 
Resolves #23282
Resolves #23104

Issue:
When buffering is enabled, first time when we read particular property slot, we create expression to read into buffer and out of the buffer.
We mistakenly bypassed changing expression to read from value buffer when same property slot was being read again, causing cast errors
Also matches the type being read out of the buffered data reader
@smitpatel smitpatel mentioned this issue Nov 12, 2020
Merged
@ajcvickers ajcvickers modified the milestones: 6.0.0, 5.0.1 Nov 16, 2020
smitpatel added a commit that referenced this issue Nov 17, 2020
@smitpatel
Query: Properly generate expression to read from BufferedDataReader
fad3c60 
Resolves #23282
Resolves #23104

Issue:
When buffering is enabled, first time when we read particular property slot, we create expression to read into buffer and out of the buffer.
We mistakenly bypassed changing expression to read from value buffer when same property slot was being read again, causing cast errors
Also matches the type being read out of the buffered data reader
@smitpatel smitpatel mentioned this issue Nov 24, 2020
Closed
@ajcvickers ajcvickers changed the title Buffering data reader may not be preserving types correctly Properly generate expression to read provider-specific types from BufferedDataReader Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported regression Servicing-approved type-bug
Projects
None yet
Milestone
5.0.1
Development

No branches or pull requests
3 participants
@ajcvickers @smitpatel @AndriySvyryd