Query: Make EF.Functions.DateDiff* SqlServer specific

Resolves #11038
dotnet · Mar 1, 2018 · 76d0d43 · 76d0d43
1 parent 04ade14
commit 76d0d43
Show file tree

Hide file tree

Showing 9 changed files with 735 additions and 1,087 deletions.
diff --git a/samples/OracleProvider/test/OracleProvider.FunctionalTests/Query/DbFunctionsOracleTest.cs b/samples/OracleProvider/test/OracleProvider.FunctionalTests/Query/DbFunctionsOracleTest.cs
@@ -27,23 +27,5 @@ public override void String_Like_Literal()
                 Assert.Equal(19, count); // TODO: case-sensitive - use REGEXP_LIKE function?
             }
         }
-
-        [ConditionalFact(Skip = "See issue#10520")]
-        public override void DateDiff_Microsecond()
-        {
-            base.DateDiff_Microsecond();
-        }
-
-        [ConditionalFact(Skip = "See issue#10520")]
-        public override void DateDiff_Millisecond()
-        {
-            base.DateDiff_Millisecond();
-        }
-
-        [ConditionalFact(Skip = "See issue#10520")]
-        public override void DateDiff_Nanosecond()
-        {
-            base.DateDiff_Nanosecond();
-        }
     }
 }
diff --git a/src/EFCore.Specification.Tests/Query/DbFunctionsTestBase.cs b/src/EFCore.Specification.Tests/Query/DbFunctionsTestBase.cs
@@ -51,114 +51,6 @@ public virtual void String_Like_Literal_With_Escape()
             }
         }
 
-        [ConditionalFact]
-        public virtual void DateDiff_Year()
-        {
-            using (var context = CreateContext())
-            {
-                var count = context.Orders
-                    .Count(c => EF.Functions.DateDiffYear(c.OrderDate, DateTime.Now) == 0);
-
-                Assert.Equal(0, count);
-            }
-        }
-
-        [ConditionalFact]
-        public virtual void DateDiff_Month()
-        {
-            using (var context = CreateContext())
-            {
-                var count = context.Orders
-                    .Count(c => EF.Functions.DateDiffMonth(c.OrderDate, DateTime.Now) == 0);
-
-                Assert.Equal(0, count);
-            }
-        }
-
-        [ConditionalFact]
-        public virtual void DateDiff_Day()
-        {
-            using (var context = CreateContext())
-            {
-                var count = context.Orders
-                    .Count(c => EF.Functions.DateDiffDay(c.OrderDate, DateTime.Now) == 0);
-
-                Assert.Equal(0, count);
-            }
-        }
-
-        [ConditionalFact]
-        public virtual void DateDiff_Hour()
-        {
-            using (var context = CreateContext())
-            {
-                var count = context.Orders
-                    .Count(c => EF.Functions.DateDiffHour(c.OrderDate, DateTime.Now) == 0);
-
-                Assert.Equal(0, count);
-            }
-        }
-
-        [ConditionalFact]
-        public virtual void DateDiff_Minute()
-        {
-            using (var context = CreateContext())
-            {
-                var count = context.Orders
-                    .Count(c => EF.Functions.DateDiffMinute(c.OrderDate, DateTime.Now) == 0);
-
-                Assert.Equal(0, count);
-            }
-        }
-
-        [ConditionalFact]
-        public virtual void DateDiff_Second()
-        {
-            using (var context = CreateContext())
-            {
-                var count = context.Orders
-                    .Count(c => EF.Functions.DateDiffSecond(c.OrderDate, DateTime.Now) == 0);
-
-                Assert.Equal(0, count);
-            }
-        }
-
-        [ConditionalFact]
-        public virtual void DateDiff_Millisecond()
-        {
-            using (var context = CreateContext())
-            {
-                var count = context.Orders
-                    .Count(c => EF.Functions.DateDiffMillisecond(DateTime.Now, DateTime.Now.AddDays(1)) == 0);
-
-                Assert.Equal(0, count);
-            }
-        }
-
-        [ConditionalFact]
-        public virtual void DateDiff_Microsecond()
-        {
-            using (var context = CreateContext())
-            {
-                var count = context.Orders
-                    .Count(c => EF.Functions.DateDiffMicrosecond(DateTime.Now, DateTime.Now.AddSeconds(1)) == 0);
-
-                Assert.Equal(0, count);
-            }
-        }
-
-        [ConditionalFact]
-        public virtual void DateDiff_Nanosecond()
-        {
-            using (var context = CreateContext())
-            {
-                var count = context.Orders
-                    .Count(c => EF.Functions.DateDiffNanosecond(DateTime.Now, DateTime.Now.AddSeconds(1)) == 0);
-
-                Assert.Equal(0, count);
-            }
-        }
-
         protected NorthwindContext CreateContext() => Fixture.CreateContext();
     }
 }