Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general documentation page for Ubuntu Chiseled #4968

Merged
merged 10 commits into from
Oct 31, 2023

Conversation

lbussell
Copy link
Contributor

Part of #4914

Comment on lines +104 to +105
If you are writing to bind or volume mounted directories, you will need to make sure the directory gives the correct permissions to the non-root user.
You can check the user ID that a container will use by running the following command:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if there was a good "official" doc page we could link to for managing this with containers but I haven't come across anything very good.

@lbussell lbussell requested a review from jander-msft as a code owner October 26, 2023 22:28
lbussell and others added 3 commits October 27, 2023 09:59
Co-authored-by: Justin Anderson <jander-msft@users.noreply.github.com>
Using the github.com link instead of a relative link here because it can be reached from MCR/DH.
## Common issues adopting distroless containers

### Trying to invoke a shell
### How can I write my Dockerfile to work without a shell?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel like we're actually answering this question. We're just saying "make sure don't run shell commands". We need to be more specific about this. One thing is to mention the use of multi-stage Dockerfiles as a pattern to help with executing necessary commands. The other is to call out the use of app code that may be running Process.Start with UseShellExecute or whatever it's called and how that would be bad.

Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few suggested edits.

Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants