add images to build runtime on FreeBSD #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see failures and but that seems unrelated to my change. |
mthalman
reviewed
Mar 31, 2020
| { | ||
| "dockerfile": "src/ubuntu/18.04/cross/freebsd/11", | ||
| "os": "linux", | ||
| "osVersion": "freebsd.11", |
There was a problem hiding this comment.
Suggested change
| "osVersion": "freebsd.11", | |
| "osVersion": "ubuntu18.04", |
There was a problem hiding this comment.
updated. Is there place in manifest to reflect target OS/arch? Or is it only by the tag?
jashook
approved these changes
Mar 31, 2020
This was referenced Apr 1, 2020
|
Ok, the fix to the infra is in to fix the disk space issue. I'll rerun the build. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run dotnet-buildtools-prereqs-docker-ubuntu18, dotnet-buildtools-prereqs-docker-eng |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@wfurt - Builds are running clean now. Is this ready to merge? |
|
yes, I hope so. There may be some minor tweaks or build surprises but having container would allow me to try with CI build. |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps dotnet/arcade#5100
build-rootfs.sh needs few more package to construct roots for FreeBSD.
They all seems pretty small so I added them to crossdeps to avoid need to create new base image for pre-build hook.
I'm not sure with naming but it seems os and base directory should reflect base container OS and not target.
I also noticed arcade checkout taking some time on my home machine. Since do not seems to need history, I changed clone to shallow copy.