Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace docs for logging #8515

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Add namespace docs for logging #8515

merged 3 commits into from
Oct 18, 2022

Conversation

maryamariyan
Copy link
Member

@maryamariyan maryamariyan commented Oct 14, 2022

@maryamariyan maryamariyan requested a review from a team as a code owner October 14, 2022 23:46
@ghost ghost assigned maryamariyan Oct 14, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Oct 14, 2022
@maryamariyan maryamariyan added area-Extensions-Logging and removed area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. labels Oct 14, 2022
@ghost
Copy link

ghost commented Oct 14, 2022

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to dotnet/runtime#43918

cc @Nick-Stanton @tarekgh @gewarren @carlossanlop

Author: maryamariyan
Assignees: maryamariyan
Labels:

area-Extensions-Logging

Milestone: -

@opbld34
Copy link

opbld34 commented Oct 15, 2022

Learn Build status updates of commit 1daffe6:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/ns-Microsoft.Extensions.Logging.Abstractions.xml ⚠️Warning View Details
xml/ns-Microsoft.Extensions.Logging.xml ⚠️Warning View Details
xml/ns-Microsoft.Extensions.Logging.Configuration.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.Console.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.Debug.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.EventLog.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.EventSource.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.TraceSource.xml ✅Succeeded View

xml/ns-Microsoft.Extensions.Logging.Abstractions.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.Console.ILogger'.

xml/ns-Microsoft.Extensions.Logging.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.Console.ILogger'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Nick-Stanton
Copy link
Member

Nick-Stanton commented Oct 17, 2022

The reference failures may be due to ILogger being an interface. See the source for what the prefixing character means in terms of identification.

Also, it may just be T:Microsoft.Extensions.Logger.ILogger.

@opbld33
Copy link

opbld33 commented Oct 17, 2022

Learn Build status updates of commit 0158f17:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-Microsoft.Extensions.Logging.Abstractions.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.Configuration.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.Console.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.Debug.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.EventLog.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.EventSource.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.TraceSource.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld33
Copy link

opbld33 commented Oct 17, 2022

Learn Build status updates of commit bfcf511:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-Microsoft.Extensions.Logging.Abstractions.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.Configuration.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.Console.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.Debug.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.EventLog.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.EventSource.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.TraceSource.xml ✅Succeeded View
xml/ns-Microsoft.Extensions.Logging.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@maryamariyan maryamariyan merged commit d3e4f6b into main Oct 18, 2022
@maryamariyan maryamariyan deleted the logging-doc branch October 18, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants