Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler warnings for Thread.Abort #4616

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Compiler warnings for Thread.Abort #4616

merged 3 commits into from
Aug 7, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Aug 6, 2020

Contributes to dotnet/docs#19625.

Ignore whitespace changes in diff.

@gewarren gewarren requested review from GrabYourPitchforks and a team August 6, 2020 16:12
BillWagner
BillWagner approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit 96171ef into dotnet:master Aug 7, 2020
@gewarren gewarren deleted the thread-abort branch August 7, 2020 20:48
@gewarren
Copy link
Contributor Author

gewarren commented Aug 7, 2020

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gewarren @BillWagner @GrabYourPitchforks