Note interactions between JIT optimizations and stack root reporting #8819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a short note about interactions between JIT optimizations and stack root reporting since it is frequently discussed topic. The full discussion is in https://github.com/dotnet/coreclr/issues/5826#issuecomment-226574611
stephentoub
reviewed
Nov 2, 2018
| @@ -166,7 +166,7 @@ ms.author: "ronpet" | |||
|
|
|||
| The garbage collector uses the following information to determine whether objects are live: | |||
|
|
|||
| - **Stack roots**. Stack variables provided by the just-in-time (JIT) compiler and stack walker. | |||
| - **Stack roots**. Stack variables provided by the just-in-time (JIT) compiler and stack walker. Note that JIT optimizations can lengthen and shorten region of code within which the stack variable is reported to the garbage collector. | |||
There was a problem hiding this comment.
Both optimizations and debug flags, right? (Though I guess the latter could be assumed as just lack of optimizations?)
Also nit: "region of code" => "regions of code" or "the region of code"
rpetrusha
suggested changes
Nov 2, 2018
| @@ -166,7 +166,7 @@ ms.author: "ronpet" | |||
|
|
|||
| The garbage collector uses the following information to determine whether objects are live: | |||
|
|
|||
| - **Stack roots**. Stack variables provided by the just-in-time (JIT) compiler and stack walker. | |||
| - **Stack roots**. Stack variables provided by the just-in-time (JIT) compiler and stack walker. Note that JIT optimizations can lengthen and shorten region of code within which the stack variable is reported to the garbage collector. | |||
There was a problem hiding this comment.
region of code --> the region of code
the stack variable is --> stack variables are
stephentoub
approved these changes
Nov 2, 2018
rpetrusha
approved these changes
Nov 2, 2018
|
Thanks for making the changes, @jkotas. I'll merge your PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a short note about interactions between JIT optimizations and stack root reporting since it is frequently discussed topic. The full discussion is in https://github.com/dotnet/coreclr/issues/5826#issuecomment-226574611