Skip to content

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 23, 2025

@Youssef1313 Youssef1313 requested review from IEvangelist and a team as code owners September 23, 2025 14:09
@dotnetrepoman dotnetrepoman bot added this to the September 2025 milestone Sep 23, 2025
@Youssef1313 Youssef1313 requested review from Evangelink, nohwnd and gewarren and removed request for a team and IEvangelist September 23, 2025 14:09
Copy link
Member

@tkapin tkapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, recommending to run through copilot yet to polish the stylistics (unless that has been done already).

Co-authored-by: Jakub Jareš <me@jakubjares.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@Copilot Copilot AI review requested due to automatic review settings October 8, 2025 09:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR documents the migration process from Microsoft.Testing.Platform v1 to v2, providing guidance for users upgrading to the new version. The documentation covers breaking changes and behavioral differences between versions.

Key changes:

  • Creates comprehensive migration documentation for Microsoft.Testing.Platform v2
  • Adds table of contents entry for the new migration guide

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
docs/core/testing/microsoft-testing-platform-migration-from-v1-to-v2.md New migration guide documenting breaking changes and behavior differences when upgrading from v1 to v2
docs/navigate/devops-testing/toc.yml Adds navigation entry for the migration guide in the testing documentation table of contents

Comment on lines 1 to 7
---
title: Microsoft.Testing.Platform migration from v1 to v2
description: Learn about migrating to Microsoft.Testing.Platform v2.
author: Youssef1313
ms.author: ygerges
ms.date: 09/23/2025
---
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-generated content should include 'ai-usage: ai-generated' in the frontmatter according to .NET documentation guidelines.

Copilot generated this review using guidance from repository custom instructions.

Comment on lines 35 to 37
- A `CancellationToken` parameter was added to `IOutputDevice.DisplayAsync`.
- Methods in `ITestSessionLifetimeHandler` interface are changed to have a `ITestSessionContext` parameter instead of both `SessionUid` and `CancellationToken` parameters.
- `IDataConsumer` is moved from `Microsoft.Testing.Platform.Extensions.TestHost` namespace to `Microsoft.Testing.Platform.Extensions`.
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordered and unordered lists should use complete sentences with proper punctuation, ending with a period if it's more than three words according to .NET documentation guidelines.

Copilot generated this review using guidance from repository custom instructions.


Running MTP test projects with .NET 10 SDK now requires opting-in to the MTP-based `dotnet test` and can no longer be run with the VSTest-based implementation, which was previously enabled by `TestingPlatformDotnetTestSupport` MSBuild property in MTP v1.

To opt-in the MTP-based implementation, create global.json in repository or solution root (or update existing global.json if you have one already), to have test runner set as Microsoft.Testing.Platform, as shown in the following example:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren This global.json feature is RC2 only. Is it fine to get this merged now? Or should we wait until RC2 is shipped?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion, I think it's best to wait a week.

…-to-v2.md

Co-authored-by: Jakub Jareš <me@jakubjares.com>

### API signature changes

- A `CancellationToken` parameter was added to <xref:Microsoft.Testing.Platform.OutputDevice.IOutputDevice.DisplayAsync(Microsoft.Testing.Platform.Extensions.OutputDevice.IOutputDeviceDataProducer,Microsoft.Testing.Platform.OutputDevice.IOutputDeviceData)?displayProperty=nameWithType>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Youssef1313 Do you use the xref-helper extension to help with xrefs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I used it.


Running MTP test projects with .NET 10 SDK now requires opting-in to the MTP-based `dotnet test` and can no longer be run with the VSTest-based implementation, which was previously enabled by `TestingPlatformDotnetTestSupport` MSBuild property in MTP v1.

To opt-in the MTP-based implementation, create global.json in repository or solution root (or update existing global.json if you have one already), to have test runner set as Microsoft.Testing.Platform, as shown in the following example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion, I think it's best to wait a week.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants