Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up xref issues, and remove section #40434

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Fix up xref issues, and remove section #40434

merged 4 commits into from
Apr 10, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Apr 10, 2024 •
edited by github-actions bot
Loading

Summary

Fix up xref issues, and remove section

Fixes #40433

Internal previews

📄 File 🔗 Preview link
docs/core/extensions/service-discovery.md Service discovery in .NET

@dotnet-bot dotnet-bot added this to the April 2024 milestone Apr 10, 2024
@IEvangelist IEvangelist marked this pull request as draft April 10, 2024 17:28
@IEvangelist IEvangelist marked this pull request as ready for review April 10, 2024 17:37
ReubenBond
ReubenBond approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@ReubenBond ReubenBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

@IEvangelist IEvangelist enabled auto-merge (squash) April 10, 2024 17:43
ReubenBond
ReubenBond approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@ReubenBond ReubenBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments

@IEvangelist IEvangelist merged commit 2c1b7aa into dotnet:main Apr 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReubenBond ReubenBond ReubenBond approved these changes

@tdykstra tdykstra Awaiting requested review from tdykstra

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
April 2024
Development

Successfully merging this pull request may close these issues.

Address Service Discovery API changes
3 participants
@IEvangelist @ReubenBond @dotnet-bot