Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for CA1514 #37229

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Add documentation for CA1514 #37229

merged 3 commits into from
Oct 5, 2023

Conversation

mpidash
Copy link
Contributor

@mpidash mpidash commented Sep 23, 2023 •
edited by github-actions bot
Loading

@mpidash mpidash requested review from gewarren and a team as code owners September 23, 2023 15:10
@dotnet-bot dotnet-bot added this to the September 2023 milestone Sep 23, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Sep 23, 2023
gewarren
gewarren approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the docs. I left a few suggestions (our grammar checker doesn't like sentences that start with -ing words).

docs/fundamentals/code-analysis/quality-rules/ca1514.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca1514.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/index.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/maintainability-warnings.md Outdated Show resolved Hide resolved
@mpidash @gewarren
Apply suggestions from code review
2a5c92e 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren gewarren enabled auto-merge (squash) September 25, 2023 19:05
@BillWagner BillWagner closed this Oct 5, 2023
auto-merge was automatically disabled October 5, 2023 18:13

Pull request was closed

@BillWagner BillWagner reopened this Oct 5, 2023
@BillWagner BillWagner enabled auto-merge (squash) October 5, 2023 18:13
@BillWagner BillWagner merged commit b015080 into dotnet:main Oct 5, 2023
14 checks passed
@mpidash mpidash deleted the ca1514 branch March 21, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@mpidash @gewarren @BillWagner @dotnet-bot