Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config binding breaking change #36434

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Config binding breaking change #36434

merged 2 commits into from
Jul 28, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 28, 2023 •
edited by github-actions bot
Loading

@dotnet-bot dotnet-bot added this to the July 2023 milestone Jul 28, 2023
@gewarren gewarren requested review from tarekgh and a team July 28, 2023 00:45
tarekgh
tarekgh approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thnaks!

BillWagner
BillWagner approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit fab73a8 into dotnet:main Jul 28, 2023
7 checks passed
@gewarren gewarren deleted the config-binding branch July 28, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@tarekgh tarekgh tarekgh approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.

[Breaking change]: Stop skipping configuration binding a dictionary with a key that has empty value
4 participants
@gewarren @BillWagner @tarekgh @dotnet-bot