Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VS Code tutorial series for .NET 6 #26631

Merged
merged 13 commits into from
Oct 29, 2021
Merged

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Oct 22, 2021

Fixes #25834
Also updates some things that were missed when the Visual Studio tutorials were updated.

File Type File Name Published Url
Content docs/core/tutorials/with-visual-studio-code.md https://review.docs.microsoft.com/en-us/dotnet/core/tutorials/with-visual-studio-code?branch=pr-en-us-26631
Content docs/core/tutorials/debugging-with-visual-studio-code.md https://review.docs.microsoft.com/en-us/dotnet/core/tutorials/debugging-with-visual-studio-code?branch=pr-en-us-26631
Content docs/core/tutorials/publishing-with-visual-studio-code.md https://review.docs.microsoft.com/en-us/dotnet/core/tutorials/publishing-with-visual-studio-code?branch=pr-en-us-26631
Content docs/core/tutorials/library-with-visual-studio-code.md https://review.docs.microsoft.com/en-us/dotnet/core/tutorials/library-with-visual-studio-code?branch=pr-en-us-26631
Content docs/core/tutorials/testing-library-with-visual-studio-code.md https://review.docs.microsoft.com/en-us/dotnet/core/tutorials/testing-library-with-visual-studio-code?branch=pr-en-us-26631

@tdykstra tdykstra changed the title WIP: Update VS Code tutorial series for .NET 6 Update VS Code tutorial series for .NET 6 Oct 25, 2021
@tdykstra tdykstra requested review from adegeo and a team October 25, 2021 22:26
@tdykstra tdykstra marked this pull request as ready for review October 25, 2021 22:26
@adegeo
Copy link
Contributor

adegeo commented Oct 26, 2021

@tdykstra I'll review this today. tomorrow.... 😁

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. There is a main step missing in the debugging with vs article, hence requesting changes. But I have a lot of other little feedback too.

One thing I was thinking about was the second code folder for the article: library-with-visual-studio-6-0 I've run into this with WPF XAML stuff and I've adopted the underscore as a separator between the name of the article and some identifier simply because it visually differentiates the article name and id: library-with-visual-studio_6-0 (considering we're not supposed to have underscores in the article file name)


The breakpoint is located after a `Console.ReadLine` method call. The **Debug Console** doesn't accept terminal input for a running program. To handle terminal input while debugging, you can use the integrated terminal (one of the Visual Studio Code windows) or an external terminal. For this tutorial, you use the integrated terminal.

1. Open *.vscode/launch.json*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, the launch file doesn't exist. If the user followed the previous article, they just have a normal console app that isn't configured to debug/run within VSCode. They need to

  1. Select the on Run & Debug tab
  2. Press the Run & Debug button

image

Then they'll be presented with the option to generate a launch.json file for the .NET environment:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The launch file is created in step 7 of Tutorial 1 Create the app section. when you open a .cs file for the first time. That's the reason for the step text "Select Yes if Visual Studio Code prompts you to add the missing assets to build and debug your app."

@@ -44,47 +44,46 @@ Create a .NET console app project named "HelloWorld".

1. In the **Additional information** dialog, select **.NET 6.0 (Preview)**, and then select **Create**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (Preview) is going to have to be removed from framework selection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On GA-day I'll do a search through the repo for instances of "Preview" that need to go away.

tdykstra and others added 2 commits October 27, 2021 13:21
Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering you looked at all my feedback, I'll approve while you get things fixed. If you want me to look over it again (if you do some pivot tests) tag me and I'll check them out.

@tdykstra tdykstra merged commit bec0917 into dotnet:main Oct 29, 2021
@tdykstra tdykstra deleted the net6vscodetut branch October 29, 2021 16:22
@tdykstra tdykstra added the okr-freshness OKR: Freshness of content label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 6 update for VS Code tutorial series
3 participants