-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VS Code tutorial series for .NET 6 #26631
Conversation
@tdykstra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. There is a main step missing in the debugging with vs article, hence requesting changes. But I have a lot of other little feedback too.
One thing I was thinking about was the second code folder for the article: library-with-visual-studio-6-0
I've run into this with WPF XAML stuff and I've adopted the underscore as a separator between the name of the article and some identifier simply because it visually differentiates the article name and id: library-with-visual-studio_6-0
(considering we're not supposed to have underscores in the article file name)
|
||
The breakpoint is located after a `Console.ReadLine` method call. The **Debug Console** doesn't accept terminal input for a running program. To handle terminal input while debugging, you can use the integrated terminal (one of the Visual Studio Code windows) or an external terminal. For this tutorial, you use the integrated terminal. | ||
|
||
1. Open *.vscode/launch.json*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, the launch file doesn't exist. If the user followed the previous article, they just have a normal console app that isn't configured to debug/run within VSCode. They need to
- Select the on Run & Debug tab
- Press the Run & Debug button
Then they'll be presented with the option to generate a launch.json file for the .NET environment:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The launch file is created in step 7 of Tutorial 1 Create the app section. when you open a .cs file for the first time. That's the reason for the step text "Select Yes if Visual Studio Code prompts you to add the missing assets to build and debug your app."
@@ -44,47 +44,46 @@ Create a .NET console app project named "HelloWorld". | |||
|
|||
1. In the **Additional information** dialog, select **.NET 6.0 (Preview)**, and then select **Create**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The (Preview)
is going to have to be removed from framework selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On GA-day I'll do a search through the repo for instances of "Preview" that need to go away.
Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering you looked at all my feedback, I'll approve while you get things fixed. If you want me to look over it again (if you do some pivot tests) tag me and I'll check them out.
Fixes #25834
Also updates some things that were missed when the Visual Studio tutorials were updated.