Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA1861 Analyzer and code fix documentation: AvoidConstArrays #25659

Merged
merged 21 commits into from
May 11, 2023
Merged

CA1861 Analyzer and code fix documentation: AvoidConstArrays #25659

merged 21 commits into from
May 11, 2023

Conversation

steveberdy
Copy link
Contributor

@steveberdy steveberdy commented Aug 16, 2021 •
edited by github-actions bot
Loading

@steveberdy steveberdy requested review from gewarren and a team as code owners August 16, 2021 19:20
@dotnet-bot dotnet-bot added this to the August 2021 milestone Aug 16, 2021
This was referenced Aug 16, 2021
Closed
Merged
@gewarren gewarren added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Aug 16, 2021
gewarren
gewarren approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add an entry to https://github.com/dotnet/docs/blob/main/docs/fundamentals/code-analysis/quality-rules/index.md? Thanks for recreating the PR!

docs/fundamentals/code-analysis/quality-rules/ca1839.md Outdated Show resolved Hide resolved
@wzchua
Copy link
Contributor

wzchua commented Aug 17, 2021

CA1839 is already used, refer to #23900

@steveberdy
Copy link
Contributor Author

@wzchua I'll be retargeting the .NET 6 release branch, so that will be changing.

@steveberdy steveberdy changed the title CA1839 Analyzer and code fix documentation: Avoid const arrays CA1848 Analyzer and code fix documentation: Avoid const arrays Aug 17, 2021
@steveberdy steveberdy mentioned this pull request Aug 17, 2021
Merged
@steveberdy steveberdy changed the title CA1848 Analyzer and code fix documentation: Avoid const arrays CA1849 Analyzer and code fix documentation: Avoid const arrays Aug 17, 2021
@steveberdy steveberdy changed the title CA1849 Analyzer and code fix documentation: Avoid const arrays CA1849 Analyzer and code fix documentation: AvoidConstArrays Aug 17, 2021
steveberdy referenced this pull request Sep 1, 2021
@IEvangelist
Bot 🤖 generated "What's new article"
02a57a7
@steveberdy steveberdy mentioned this pull request Sep 1, 2021
Merged
@BillWagner BillWagner modified the milestones: August 2021, September 2021 Sep 8, 2021
@gewarren gewarren removed this from the September 2021 milestone Oct 4, 2021
@steveberdy steveberdy changed the title CA1849 Analyzer and code fix documentation: AvoidConstArrays CA1854 Analyzer and code fix documentation: AvoidConstArrays May 27, 2022
@steveberdy
Copy link
Contributor Author

Still awaiting merge of the analyzer. Please don't merge these docs yet.

@dotnet-bot dotnet-bot added this to the June 2022 milestone Jun 3, 2022
@gewarren gewarren changed the title CA1854 Analyzer and code fix documentation: AvoidConstArrays CA1855 Analyzer and code fix documentation: AvoidConstArrays Jun 23, 2022
@gewarren gewarren marked this pull request as draft January 10, 2023 20:04
@steveberdy steveberdy changed the title CA1855 Analyzer and code fix documentation: AvoidConstArrays CA1861 Analyzer and code fix documentation: AvoidConstArrays May 10, 2023
@steveberdy steveberdy marked this pull request as ready for review May 11, 2023 01:25
@steveberdy steveberdy closed this May 11, 2023
@steveberdy steveberdy reopened this May 11, 2023
@dotnet-bot dotnet-bot modified the milestones: June 2022, May 2023 May 11, 2023
@steveberdy
Copy link
Contributor Author

Thank you for your patience! The analyzer has been merged and I have updated the docs accordingly. Requesting review.

@gewarren gewarren enabled auto-merge (squash) May 11, 2023 15:11
@gewarren gewarren merged commit bf54cd0 into dotnet:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) dotnet-fundamentals/svc
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@steveberdy @wzchua @gewarren @BillWagner @dotnet-bot