Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit namespaces - breaking change #25250

Merged
merged 5 commits into from
Jul 23, 2021
Merged

Implicit namespaces - breaking change #25250

merged 5 commits into from
Jul 23, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 20, 2021 •
edited
Loading

Fixes #25066

Preview links:

@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 20, 2021
@gewarren gewarren requested review from dsplaisted and a team July 20, 2021 22:34
@gewarren
Copy link
Contributor Author

@BillWagner My list of default namespaces doesn't seem to match up with your console app list in https://docs.microsoft.com/en-us/dotnet/core/tutorials/top-level-templates#use-the-new-program-style. Ideas?

@BillWagner
Copy link
Member

@gewarren These were still e discussed when I wrote that article. We should probably go with the list in #25066 here and in that article.

Ping @dsplaisted and @KathleenDollard for verification on the list of implicit usings.

tdykstra
tdykstra approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the outstanding question.

@gewarren gewarren merged commit c1fae06 into dotnet:main Jul 23, 2021
@gewarren gewarren deleted the implicit-namespaces branch July 23, 2021 18:47
@gewarren
Copy link
Contributor Author

Thanks for the review Tom!

@BillWagner BillWagner mentioned this pull request Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@tdykstra tdykstra tdykstra approved these changes

@dsplaisted dsplaisted Awaiting requested review from dsplaisted

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2021
Development

Successfully merging this pull request may close these issues.

SDK support for implicit namespaces in C# projects
5 participants
@gewarren @BillWagner @tdykstra @Youssef1313 @dotnet-bot