Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in add-aspire-existing-app.md #146

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix typo in add-aspire-existing-app.md #146

merged 1 commit into from
Dec 8, 2023

Conversation

ericmutta
Copy link
Contributor

@ericmutta ericmutta commented Dec 8, 2023 •
edited by github-actions bot
Loading

The sentence:

Visual Studio add two new...

Should read:

Visual Studio adds two new

Internal previews

📄 File 🔗 Preview link
docs/get-started/add-aspire-existing-app.md Tutorial: Add .NET Aspire to an existing .NET 8 microservices app

@ericmutta
Fix typo in add-aspire-existing-app.md
9d2080c 
The sentence:

> Visual Studio **add** two new...

Should read:

> Visual Studio **adds** two new
IEvangelist
IEvangelist approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist enabled auto-merge (squash) December 8, 2023 13:57
@IEvangelist IEvangelist added the getting-started Content related to getting started. label Dec 8, 2023
@IEvangelist IEvangelist merged commit b6ff416 into dotnet:main Dec 8, 2023
@ericmutta
Copy link
Contributor Author

Thanks @IEvangelist for the super fast followup 🚀 @danmoseley encouraged me to check out Aspire and I really like what I am seeing so far (especially that dashboard functionality which I've had to manually build in previous projects). I appreciate all the work you guys do to make our lives easier as .NET developers 🔥 🙏

@adegeo adegeo added kudos Indicates issues that are compliments about docs [org][type][category] and removed 🥳 kudos labels Dec 8, 2023
@danmoseley
Copy link
Member

@ericmutta Perhaps there's an issue marked good first issue that might interest you.

IEvangelist pushed a commit to IEvangelist/docs-aspire that referenced this pull request Dec 8, 2023
@ericmutta @IEvangelist
Fix typo in add-aspire-existing-app.md (dotnet#146)
5b584d7 
The sentence:

> Visual Studio **add** two new...

Should read:

> Visual Studio **adds** two new
@ericmutta
Copy link
Contributor Author

ericmutta commented Dec 8, 2023 •
edited
Loading

@danmoseley I found and fixed one that was added just a few hours ago! It's actually pretty cool to get in on a project when it is still so young...now I know for sure I am getting fired from my day job this year, because this is getting addictive 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
getting-started Content related to getting started. kudos Indicates issues that are compliments about docs [org][type][category]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericmutta @danmoseley @IEvangelist @adegeo