Prioritize AzureCliCredential for secret-manager #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garath
commented
Mar 1, 2024
src/SecretManager/Microsoft.DncEng.SecretManager/ITokenCredentialProvider.cs
Show resolved
Hide resolved
|
I'm running the weekly build against this branch to confirm it works: #2024022911 • Prioritize AzureCliCredential for secret-manager |
dkurepa
reviewed
Mar 1, 2024
src/SecretManager/Microsoft.DncEng.SecretManager/SecretManagerCredentialProvider.cs
Outdated
Show resolved
Hide resolved
premun
previously approved these changes
Mar 1, 2024
|
|
||
| public interface ITokenCredentialProvider | ||
| { | ||
| public Task<TokenCredential> GetCredentialAsync(); |
There was a problem hiding this comment.
Suggested change
| public Task<TokenCredential> GetCredentialAsync(); | |
| Task<TokenCredential> GetCredentialAsync(); |
AlitzelMendez
approved these changes
Mar 1, 2024
This was referenced Mar 1, 2024
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/dnceng#2084
Prioritize using AzureCliCredential to eliminate confusion in CI.