Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tables in lists #512

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Fix tables in lists #512

merged 2 commits into from
Mar 18, 2022

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Mar 17, 2022

This is now ready for review.

This then enables the paragraphs following them to be correctly within the table. This change is just whitespace.

Fixes dotnet#441.

The change around line 5612 is to replace a tab with four spaces.
@jskeet jskeet marked this pull request as ready for review March 18, 2022 07:00
@jskeet jskeet requested a review from BillWagner March 18, 2022 07:00
@jskeet
Copy link
Contributor Author

jskeet commented Mar 18, 2022

Fixes #441.

@jskeet
Copy link
Contributor Author

jskeet commented Mar 18, 2022

Note: we should validate what happens to 11.9.6 when both this and #515 are merged (that's got an example in a triply-nested list). I hope it'll be okay, but it's worth checking.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @jskeet

Let's :shipit:

@jskeet jskeet merged commit 9e6615d into dotnet:draft-v6 Mar 18, 2022
@jskeet jskeet deleted the table-in-list branch March 18, 2022 14:55
@jskeet
Copy link
Contributor Author

jskeet commented Mar 18, 2022

Thanks - will rebase #515 on this, as it's very likely to have merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants