Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first-class span types proposal #7904

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

333fred
Copy link
Member

@333fred 333fred commented Feb 3, 2024

No description provided.

@333fred 333fred requested a review from a team as a code owner February 3, 2024 00:50
@333fred 333fred mentioned this pull request Feb 3, 2024
4 tasks
@CyrusNajmabadi
Copy link
Member

Question. If we have your this, can we remove the special roles rules we have with collections to prefer spans over stays arrays? Would that just all fall out trivially once we have these conversions through preexisting better ness rules? If so, that would be lovely.

@333fred
Copy link
Member Author

333fred commented Feb 3, 2024

Question. If we have your this, can we remove the special roles rules we have with collections to prefer spans over stays arrays? Would that just all fall out trivially once we have these conversions through preexisting better ness rules? If so, that would be lovely.

Potentially. I haven't worked through all the scenarios, but I do believe it would make Span and ReadOnlySpan encompassing types in more scenarios, allowing the desired semantics to just fall out.

@CyrusNajmabadi
Copy link
Member

Lovely!

@333fred 333fred merged commit 9d12a98 into dotnet:main Feb 20, 2024
1 check passed
@333fred 333fred deleted the first-class-span-types branch February 20, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants