fix grpc link issue #6959
fix grpc link issue #6959
Conversation
| @@ -73,6 +73,11 @@ public static bool UseLazyResolution(MethodDesc method, string importModule, PIn | |||
| } | |||
| } | |||
|
|
|||
| internal static bool IsRunningOnMono() | |||
There was a problem hiding this comment.
The CoreRT compiler always runs on .NET Core today, so this condition is going to be always false.
This needs to be a new command line option. Something like --direct-pinvoke-calls:<regex to match>. And __Internal to be the default value of the option specified in the target file that you can override.
You can look for AutoInitializedAssemblies and initassembly for an existing command line option that follows similar pattern.
@MichalStrehovsky Anything you would add?
There was a problem hiding this comment.
if so, I can just remove this check
There was a problem hiding this comment.
We have added this check for __Internal to make libraries written for Mono work (#5247 (comment)). There is no default that will make everybody happy - it is why it needs to be a command line option.
There was a problem hiding this comment.
I jotted down the structure here: 2a4cac8 but I ran out of time I allocated for myself to finish this.
@szhaomsft Can you apply this commit locally and help me finish it?
What we are going for is to allow specifying the list of pinvokes that should be bound directly as a command line option. One should be able to specify e.g. --directpinvoke:"\*" --directpinvoke:"api-ms-win.*" to specify these p/invokes should be hard bound.
The MSBuild targets file will make this flexible, so that once you finish this and we merge it, you'll be able to disable resolution of __Internal by adding an Exclude item for the __Internal entry in your CSPROJ file to disable the default rule.
this is a fix to #6375
with that, one can link using dotnet core