[Linux] Implement generation dwarf debuginfo for types and vars #5542

kbaladurin · 2018-03-13T16:37:35Z

No description provided.

kbaladurin · 2018-03-13T16:39:08Z

cc @BredPet @Dmitri-Botcharnikov @alpencolt

jkotas · 2018-03-13T18:28:25Z

src/Native/ObjWriter/debugInfo/codeView/codeViewTypeBuilder.h

+//
+// type builder is used to convert .Net types into CodeView descriptors.
+//
+// Copyright (c) Microsoft. All rights reserved.


Could you please use our standard license headers on new files?

(I am fixing wrong license headers few existing files in #5544.)

jkotas · 2018-03-13T18:38:57Z

The CI tests are failing with:

Unhandled Exception: System.EntryPointNotFoundException: Unable to find an entry point named 'GetPrimitiveTypeIndex' in DLL 'objwriter'.
at ILCompiler.DependencyAnalysis.ObjectWriter.GetPrimitiveTypeIndex(IntPtr objWriter, Int32 type)

We are going to need a new objectwriter package uploaded to make this work. Do you think you could comment out this call, or ignore this exception, so that we can get the change through and work on unloading objectwriter package as separate step?

kbaladurin · 2018-03-15T12:24:57Z

@jkotas I've added commit that fixes CI tests with current objwriter package.

jkotas · 2018-03-15T20:09:13Z

src/Native/ObjWriter/debugInfo/dwarf/dwarfTypeBuilder.cpp

+//
+// dwarf type builder implementation
+//
+// Copyright (c) Microsoft. All rights reserved.


License header

jkotas · 2018-03-15T20:10:24Z

src/Native/ObjWriter/debugInfo/dwarf/dwarfGen.h

+  std::string Name;
+  int Size;
+  DwarfMemberFunctionIdTypeInfo *MethodTypeInfo;
+  std::vector<EHClauseInfo> EHClauseInfos;


How does the EHClauseInfo help with debugging - what does the debugger use it for?

It's used to emit DW_TAG_try_block and DW_TAG_catch_block DIEs. They will be used in our lldb to fix stepping though try-catch block (similar approach is used for JITed code now).

jkotas · 2018-03-15T20:11:57Z

src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/IMethodCodeNode.cs

@@ -10,6 +10,7 @@ interface IMethodCodeNode : IMethodNode, ISymbolDefinitionNode
    {
        void SetCode(ObjectNode.ObjectData data);
        void InitializeFrameInfos(FrameInfo[] frameInfos);
+        void InitializeEHClauseInfos(EHClauseInfo[] ehClauseInfos);


This may be rather called DebugEHClauseInfo to make it clear it is just for debugger.

jkotas · 2018-03-15T20:18:25Z

src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/ObjectWriter.cs

+
+        public void EmitEHClause(EHClauseInfo ehClause)
+        {
+            try


It would be useful to have all places with workarounds for the out-of-sync object writer package to be marked with a easy to search for TODO, with a link to #5177

jkotas · 2018-03-15T20:19:23Z

@davidwrighton @sandreenko Could you please take a look since you have done most work on the debuginfo emission so far?

sandreenko · 2018-03-15T20:46:36Z

Could you please insert some examples of variables in gdb after your change? For example enum, struct, 1d/2d array, class with recursion, C# String. Thanks.

- Ignore exceptions in GetPrimitiveTypeIndex and EmitEHClause methods - Call EmitDebugVarInfo only for Windows - Don't call GetMethodFunctionIdTypeIndex in EmitDebugFunctionInfo

kbaladurin · 2018-03-16T13:38:35Z

@sandreenko
Sample:

using System;
using System.Collections.Generic;
using System.Runtime.CompilerServices;
using System.Threading;
using System.Threading.Tasks;

enum TestEnum
{
    A,
    B,
    C,
    D
}

struct TestStruct
{
    public int Int;
    public float Float;
}

class TestClass
{
    public string String;
    public TestClass Object;
    public TestStruct Struct;

    public TestClass(string Name)
    {
        String = Name;
        Object = this;
        Struct.Int = 10;
        Struct.Float = 5.0F;
    }
}

class Program
{
    static int Main()
    {
        TestClass t = new TestClass("Test");
        TestEnum e = TestEnum.B;
        TestStruct s;
        s.Int = (int)e;
        int[] arr = new int[] {1, 2, 3, 4};
        int[,] arr2 = new int[,] {{1, 2}, {3, 4}};

        Console.WriteLine("Test " + t.String);

        return 0;
    }
}

gdb output:

$ gdb -q /media/kbaladurin/data/dotnet/forked/corert/tests/src/Simple/BasicThreading/bin/Debug/x64/native/BasicThreading
Reading symbols from /media/kbaladurin/data/dotnet/forked/corert/tests/src/Simple/BasicThreading/bin/Debug/x64/native/BasicThreading...done.
(gdb) b BasicThreading.cs:44
Breakpoint 1 at 0x5f7aac: file /media/kbaladurin/data/dotnet/forked/corert/tests/src/Simple/BasicThreading/BasicThreading.cs, line 44.
(gdb) r
Starting program: /media/kbaladurin/data/dotnet/forked/corert/tests/src/Simple/BasicThreading/bin/Debug/x64/native/BasicThreading 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7fffd9be1700 (LWP 27207)]

Thread 1 "BasicThreading" hit Breakpoint 1, BasicThreading_Program__Main () at /media/kbaladurin/data/dotnet/forked/corert/tests/src/Simple/BasicThreading/BasicThreading.cs:44
44	        TestClass t = new TestClass("Test");
(gdb) n
45	        TestEnum e = TestEnum.B;
(gdb) 
47	        s.Int = (int)e;
(gdb) 
48	        int[] arr = new int[] {1, 2, 3, 4};
(gdb) 
49	        int[,] arr2 = new int[,] {{1, 2}, {3, 4}};
(gdb) 
51	        Console.WriteLine("Test " + t.String);
(gdb) i locals 
e = {value__ = 1}
s = {Int = 1, Float = 0}
arr = @0x7fffd9bf6df0: {<S_P_CoreLib_System_Array> = {<Object> = {m_pEEType = 15076776}, _numComponents = 4}, m_NumComponents = 4, m_Data = 0x7fffd9bf6e00}
t = @0x7fffd9bf6dc8: {<Object> = {m_pEEType = 14698816}, String = @0xda49c8, Object = @0x7fffd9bf6dc8, Struct = {Int = 10, Float = 5}}
arr2 = @0x7fffd9bf6e18: {<S_P_CoreLib_System_Array> = {<Object> = {m_pEEType = 15105816}, _numComponents = 4}, m_NumComponents = 4, m_Bounds = {2, 2}, m_Data = 0x7fffd9bf6e38}
(gdb) p arr.m_Data[0]
$1 = 1
(gdb) p arr.m_Data[1]
$2 = 2
(gdb) p arr.m_Data[2]
$3 = 3
(gdb) p arr.m_Data[3]
$4 = 4
(gdb) p arr2.m_Data[0]
$6 = 1
(gdb) p arr2.m_Data[1]
$7 = 2
(gdb) p arr2.m_Data[2]
$8 = 3
(gdb) p arr2.m_Data[3]
$9 = 4
(gdb) p t.Object
$6 = (BasicThreading_TestClass &) @0x7fffd9bf6dc8: {<Object> = {m_pEEType = 14698816}, String = @0xda49c8, Object = @0x7fffd9bf6dc8, Struct = {Int = 10, Float = 5}}
(gdb) p t.String
$7 = (String &) @0xda49c8: {<Object> = {m_pEEType = 14719112}, _stringLength = 4, _firstChar = 84 u'T', __GCSTATICS = 0xe09888}
(gdb) p &t.String._firstChar
$8 = 0xda49d4 u"Test"

Type for enum vars is fixed in #5550

sandreenko · 2018-03-16T17:58:14Z

Thank you.
LGTM,
Does CoreRT has dependency on LLVM headers now?

jkotas

Thanks!

jkotas · 2018-03-16T18:26:15Z

Does CoreRT has dependency on LLVM headers now?

Just the object writer part. It is not built by default.

…rs (dotnet#5542)" This reverts commit d78cf62.

jkotas reviewed Mar 13, 2018

View reviewed changes

kbaladurin force-pushed the dwarf branch 6 times, most recently from 9975c38 to e319a4d Compare March 15, 2018 10:54

jkotas reviewed Mar 15, 2018

View reviewed changes

jkotas requested review from davidwrighton and sandreenko March 15, 2018 20:18

kbaladurin force-pushed the dwarf branch from e319a4d to 90e0ff2 Compare March 16, 2018 11:31

Konstantin Baladurin added 3 commits March 16, 2018 16:36

[Linux] Implement generation dwarf debuginfo for types and vars

b031f04

Fix license headers

ac266c3

Objwriter: fixes for old objwriter package

a9b5002

- Ignore exceptions in GetPrimitiveTypeIndex and EmitEHClause methods - Call EmitDebugVarInfo only for Windows - Don't call GetMethodFunctionIdTypeIndex in EmitDebugFunctionInfo

kbaladurin force-pushed the dwarf branch from 90e0ff2 to a9b5002 Compare March 16, 2018 13:38

jkotas approved these changes Mar 16, 2018

View reviewed changes

jkotas merged commit d78cf62 into dotnet:master Mar 16, 2018

This was referenced Mar 22, 2018

Dwarf DebugInfo for Types #785

Open

Dwarf DebugInfo for Vars #783

Open

A-And added a commit to A-And/corert that referenced this pull request Apr 9, 2018

Revert "[Linux] Implement generation dwarf debuginfo for types and va…

9f22b52

…rs (dotnet#5542)" This reverts commit d78cf62.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Linux] Implement generation dwarf debuginfo for types and vars #5542

[Linux] Implement generation dwarf debuginfo for types and vars #5542

kbaladurin commented Mar 13, 2018

kbaladurin commented Mar 13, 2018

jkotas Mar 13, 2018

kbaladurin Mar 14, 2018

jkotas commented Mar 13, 2018

kbaladurin commented Mar 15, 2018

jkotas Mar 15, 2018

kbaladurin Mar 16, 2018

jkotas Mar 15, 2018

kbaladurin Mar 16, 2018

jkotas Mar 15, 2018

kbaladurin Mar 16, 2018

jkotas Mar 15, 2018

kbaladurin Mar 16, 2018

jkotas commented Mar 15, 2018

sandreenko commented Mar 15, 2018

kbaladurin commented Mar 16, 2018

sandreenko commented Mar 16, 2018

jkotas left a comment

jkotas commented Mar 16, 2018

[Linux] Implement generation dwarf debuginfo for types and vars #5542

[Linux] Implement generation dwarf debuginfo for types and vars #5542

Conversation

kbaladurin commented Mar 13, 2018

kbaladurin commented Mar 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkotas commented Mar 13, 2018

kbaladurin commented Mar 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkotas commented Mar 15, 2018

sandreenko commented Mar 15, 2018

kbaladurin commented Mar 16, 2018

sandreenko commented Mar 16, 2018

jkotas left a comment

Choose a reason for hiding this comment

jkotas commented Mar 16, 2018