This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Push proper RBP frame in PUSH_COOP_PINVOKE_FRAME #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvorli
reviewed
Oct 26, 2017
| @@ -317,19 +319,14 @@ DEFAULT_FRAME_SAVE_FLAGS = PTFF_SAVE_ALL_PRESERVED + PTFF_SAVE_RSP | |||
| push_nonvol_reg rbx // .. | |||
| push_imm DEFAULT_FRAME_SAVE_FLAGS // save the register bitmask | |||
| push_register \trashReg // Thread * (unused by stackwalker) | |||
| push_nonvol_reg rbp // save caller's RBP | |||
| mov \trashReg, [rsp + 9*8] // Find the return address | |||
| push_register rbp // save caller's RBP | |||
There was a problem hiding this comment.
This is not caller's RBP anymore with this change.
|
It is strange though that the debugger would not be able to unwind what we had there before. |
This change was motivated by #4676 (comment). You can see that the stacktrace after RhpNewArrayRare is garbage. It seems to be caused by the debugger not able to deal with the non-standard RBP frame that we used have here before. |
janvorli
approved these changes
Oct 27, 2017
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with getting better stacktraces under debugger when something goes wrong.