This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Additional debug data #3932
Merged
Additional debug data #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support ByRef and Pointer types - Support base class as being a non-pointer wrapped thing - Remove unnecessary UniqueName from api - Generate struct records for enums as well as enum records - Support MemberFunction and MemberFunctionId type records - Support for this pointer records - Make api thread safe
Fixup this pointer type handling
nattress
approved these changes
Jun 21, 2017
src/ILCompiler/ILCompiler.sln
Outdated
| @@ -1,7 +1,7 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio 15 | |||
| VisualStudioVersion = 15.0.26507.0 | |||
| VisualStudioVersion = 15.0.26524.0 | |||
There was a problem hiding this comment.
Were these changes deliberate?
There was a problem hiding this comment.
No, that was my copy of VS doing "stuff"
| } | ||
| catch (OverflowException) | ||
| { | ||
| return 0; |
There was a problem hiding this comment.
Is 0 a sentinel for "invalid"? The caller doesn't do anything special with this value - or does this just quietly make us show no type info in the debugger?
There was a problem hiding this comment.
It makes the debugger quietly fail.
|
I just published ObjectWriter with your changes, could you update this PR with the 19 version? |
sandreenko
approved these changes
Jun 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more complete and correct debug data. Depends on dotnet/llilc#1082
[WIP] as it depends on dotnet/llilc#1082 to be checked in first, and a proper nuget package created.