Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

AF: !method.IsCanonicalMethod(CanonicalFormKind.Any) || method.GetCanonMethodTarget(CanonicalFormKind.Specific) == method #5710

Closed
jkotas opened this issue Apr 16, 2018 · 2 comments
Closed

AF: !method.IsCanonicalMethod(CanonicalFormKind.Any) || method.GetCanonMethodTarget(CanonicalFormKind.Specific) == method #5710

jkotas opened this issue Apr 16, 2018 · 2 comments

Comments

@jkotas
Copy link
Member

jkotas commented Apr 16, 2018

Repro:

dotnet new console -lang F#
dotnet publish -r win-x64 // make this run on debug version of the compiler

Result:

Assertion failure in ReflectableMethodNode::.ctor:

            Debug.Assert(!method.IsCanonicalMethod(CanonicalFormKind.Any) ||
                method.GetCanonMethodTarget(CanonicalFormKind.Specific) == method);
@jkotas
Copy link
Member Author

jkotas commented Apr 16, 2018

@MichalStrehovsky PTLA

@jkotas
Copy link
Member Author

jkotas commented Apr 16, 2018

#2057

MichalStrehovsky added a commit to MichalStrehovsky/corert that referenced this issue Apr 18, 2018
@MichalStrehovsky
Use fully canonical method in ready to run helpers
ba639e0 
Helper to call `Foo<string>.Virtual()` and `Foo<object>.Virtual()` is the same. Let's make fewer of them and also avoid helpers for things like `Foo<string, __Canon>.Virtual()` that put weird things in the dependency graph in the process.

Fixes dotnet#5710.
@MichalStrehovsky MichalStrehovsky mentioned this issue Apr 18, 2018
Merged
MichalStrehovsky added a commit that referenced this issue Apr 18, 2018
@MichalStrehovsky
Use fully canonical method in ready to run helpers (#5726)
93e699c 
Helper to call `Foo<string>.Virtual()` and `Foo<object>.Virtual()` is the same. Let's make fewer of them and also avoid helpers for things like `Foo<string, __Canon>.Virtual()` that put weird things in the dependency graph in the process.

Fixes #5710.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkotas