Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Use the robust class constructor runner to run class constructors #288

Closed
MichalStrehovsky opened this issue Nov 17, 2015 · 0 comments
Closed

Use the robust class constructor runner to run class constructors #288

MichalStrehovsky opened this issue Nov 17, 2015 · 0 comments
Assignees
@MichalStrehovsky
Labels
TypeSystem
Milestone
February 2016

Comments

@MichalStrehovsky
Copy link
Member

The compiler is currently emitting calls to CctorHelper class defined in StaticClassConstructionContext.cs. This is a very minimalist class constructor runner that e.g. doesn't detect cycles and the current implementation has other problems too.

We need to use the real class constructor runner from ClassConstructorRunner.cs. But for that to happen we need an equivalent of eager static constructors from .NET Native.

This might also be a good candidate for moving into Runtime.Base...
@MichalStrehovsky MichalStrehovsky self-assigned this Nov 18, 2015
@MichalStrehovsky MichalStrehovsky mentioned this issue Dec 3, 2015
Closed
@gkhanna79 gkhanna79 added this to the January milestone Dec 14, 2015
@MichalStrehovsky MichalStrehovsky modified the milestones: February, January Jan 16, 2016
MichalStrehovsky added a commit to MichalStrehovsky/corert that referenced this issue Feb 20, 2016
@MichalStrehovsky
Use full class constructor runner
7b0dcef 
Fixes dotnet#288.
@jkotas jkotas closed this as completed in 00fcf1a Feb 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichalStrehovsky MichalStrehovsky

Labels
TypeSystem
Projects
None yet
Milestone
February 2016
Development

No branches or pull requests
2 participants
@gkhanna79 @MichalStrehovsky