Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Made Quarternion's operator overloads use their respective methods #50

Closed
wants to merge 2 commits into from
Closed

Conversation

aevitas
Copy link

@aevitas aevitas commented Nov 12, 2014

Operator overloads of Quaternion now utilize their respective methods, and removed redundant "this" qualifiers in Quaternion constructor.

…n methods in the type, and specified aggressive inlining.
…rd is redundant in the Quaternion constructor.
@aevitas aevitas changed the title Issue 41 Made Quarternion's operator overloads use their respective methods Nov 12, 2014
@nguerrera
Copy link
Contributor

Thanks for this.

Merely commenting here to make it easier to recognize that it's been acknowledged. The good discussion is going on in #41.

(I came looking for that discussion based on email notification and was confused when it wasn't here.)

@mmitche
Copy link
Member

mmitche commented Nov 19, 2014

Can one of the admins verify this patch?

@davkean davkean added api-needs-work API needs work before it is approved, it is NOT ready for implementation and removed api-needs-work API needs work before it is approved, it is NOT ready for implementation labels Dec 3, 2014
@mellinoe
Copy link
Contributor

mellinoe commented Dec 4, 2014

Thanks for the submission, @aevitas . As per the discussion in #41, I don't think we have enough information to say that this is a safe change, with regards to expectations around inlining. I would imagine that this change wouldn't make a significant difference in most cases, and especially on newer versions of our JIT, but we would be sacrificing perf in cases where inlining fails, and even in the best case this would not increase performance. The code duplication is not desirable, but given that the methods are quite small, it is not a big problem to maintain at this time.

@mellinoe mellinoe closed this Dec 4, 2014
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
luhenry pushed a commit to luhenry/corefx that referenced this pull request May 24, 2018
* hide TypeForwarders from mono

* undo Char.cs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants