Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Change EnsureBufferContainsAsync to ValueTask #40519

Closed
wants to merge 1 commit into from

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Aug 22, 2019

With dotnet/coreclr#26310 this prevents it allocating Tasks in the common case

Pre
image

Post
image

/cc @stephentoub

@stephentoub
Copy link
Member

stephentoub commented Aug 22, 2019

Thanks, but I don't want to change this unless that changes go in (without it, there's only downside to such a change), and if it does go in, there's many more functions in corefx that should be changed besides this one; I don't want to do them piecemeal.

@benaadams
Copy link
Member Author

Fair enough :)

@benaadams benaadams closed this Aug 22, 2019
@benaadams benaadams deleted the EnsureBufferContainsAsync branch August 22, 2019 21:23
@karelz karelz added this to the 5.0 milestone Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants