Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Enable interactive internal tools authentication #36560

Merged
merged 3 commits into from
Apr 4, 2019

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 3, 2019

Implement interactive authentication for internal tools: NuGet/Home#7812 (comment)

Tested locally on Windows and Ubuntu (WSL) and both work fine. The authentication needs to be completed in 90sec otherwise it will fail.

Also created microsoft/artifacts-credprovider#85 to submit a minor bug in the shell script.

@ViktorHofer
Copy link
Member Author

@tmat should we bring this functionality into arcade in case other repositories also require internal tools locally for dev scenarios?

@ViktorHofer ViktorHofer changed the title Enable interactive optional tools authentication Enable interactive internal tools authentication Apr 3, 2019
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the duplication of the ToolsDir -> $(RepoRoot)\.tools -- I saw your comment that we should expose it in arcade, +1 on that.

@ViktorHofer ViktorHofer closed this Apr 4, 2019
@ViktorHofer ViktorHofer reopened this Apr 4, 2019
@safern
Copy link
Member

safern commented Apr 4, 2019

I think you have to ammend the commit and just push it, don't know what got screwed up.

@ViktorHofer
Copy link
Member Author

That has been happening the whole day already :D Usually reopening and retrying in AzDO helps.

@ViktorHofer
Copy link
Member Author

Seems not to work. I'll try your suggestion.

@ViktorHofer
Copy link
Member Author

/azp run corefx-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 4, 2019

Merging as none of this code is executed in CI (and it succeeded before).

@ViktorHofer ViktorHofer merged commit e70efa5 into dotnet:master Apr 4, 2019
@ViktorHofer ViktorHofer deleted the OptionalTools branch April 4, 2019 17:54
@karelz karelz added this to the 3.0 milestone May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants