This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Disable Aes test TestDecryptorReusability when quirk disabled or old netfx #18945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Apr 26, 2017
| @@ -13,6 +13,10 @@ public static class DecryptorReusabilty | |||
| [Fact] | |||
| public static void TestDecryptorReusability() | |||
| { | |||
| // See https://github.com/dotnet/corefx/issues/18903 for details | |||
| if (!ShouldDescriptorBeReusable()) | |||
| return; | |||
There was a problem hiding this comment.
We should do this with a ConditionalFact instead, e.g.
[ConditionalFact(nameof(ShouldDescriptorBeReusable))]That way it'll show as a skipped test in the output if the check fails.
There was a problem hiding this comment.
Didn't know about this - thanks @stephentoub !
|
@bartonjs PTAL |
krwq
commented
Apr 27, 2017
| @@ -10,7 +10,8 @@ namespace System.Security.Cryptography.Encryption.Aes.Tests | |||
|
|
|||
| public static class DecryptorReusabilty | |||
| { | |||
| [Fact] | |||
| // See https://github.com/dotnet/corefx/issues/18903 for details | |||
| [ConditionalFact(nameof(ShouldDescriptorBeReusable))] | |||
There was a problem hiding this comment.
Decryptor not Descriptor 🤦♂️
bartonjs
approved these changes
Apr 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/dotnet/corefx/issues/18903
I've manually tested the test is still being run on Core