Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing feature detection properties to DbProviderFactory #28785

Closed
roji opened this issue Feb 25, 2019 · 1 comment · Fixed by dotnet/corefx#37872
Closed

Add missing feature detection properties to DbProviderFactory #28785

roji opened this issue Feb 25, 2019 · 1 comment · Fixed by dotnet/corefx#37872
Assignees
Labels
api-approved API was approved in API review, it can be implemented area-System.Data
Milestone

Comments

@roji
Copy link
Member

roji commented Feb 25, 2019

Following up on #28768, we should add feature detection properties on DbProviderFactory for features which are optional, similar to the existing CanCreateDataSourceEnumerator. This would include:

class DbProviderFactory
{
    public virtual bool CanCreateDataAdapter { get; }
    public virtual bool CanCreateCommandBuilder { get; }
}

The default implementation would call the corresponding Create method and check if the result is null or not.

/cc @divega @ajcvickers @bricelam

@divega
Copy link
Contributor

divega commented Feb 25, 2019

Assigning to @roji on 3.0 milestone.

@divega divega changed the title Add missing feature detection methods to DbProviderFactory Add missing feature detection properties to DbProviderFactory Feb 25, 2019
roji referenced this issue in roji/corefx May 22, 2019
CanCreateDataAdapter, CanCreateCommandBuilder

Closes #35564
roji referenced this issue in roji/corefx May 30, 2019
CanCreateDataAdapter, CanCreateCommandBuilder

Closes #35564
roji referenced this issue in dotnet/corefx May 30, 2019
CanCreateDataAdapter, CanCreateCommandBuilder

Closes #35564
roji referenced this issue in roji/Npgsql Jun 17, 2019
Pin dotnet sdk to 3.0.0-preview6 and implement new ADO.NET APIs
introduced in .NET Core 3.0:
* https://github.com/dotnet/corefx/issues/35564
* https://github.com/dotnet/corefx/issues/35012

Note: we cross-target netcoreapp3.0 since the new APIs aren't yet
available in netstandard2.1, but this is expected to happen soon.

Fixes npgsql#2481
roji referenced this issue in roji/standard Jun 26, 2019
roji referenced this issue in roji/standard Jun 27, 2019
roji referenced this issue in dotnet/standard Jun 28, 2019
roji referenced this issue in npgsql/npgsql Jul 7, 2019
Pin dotnet sdk to 3.0.0-preview6 and implement new ADO.NET APIs
introduced in .NET Core 3.0:
* https://github.com/dotnet/corefx/issues/35564
* https://github.com/dotnet/corefx/issues/35012

Note: we cross-target netcoreapp3.0 since the new APIs aren't yet
available in netstandard2.1, but this is expected to happen soon.

Fixes #2481
@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 3.0 milestone Feb 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-approved API was approved in API review, it can be implemented area-System.Data
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants