This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
SpanOfT: Fix reference types #6954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkotas
commented
Aug 29, 2016
jkotas
commented
- Generic ArrayPinningHelper resulted into incorrect array data offset for reference types. Use non-generic one instead.
- Add array covariance checks to guarantee type safety.
- Generic ArrayPinningHelper resulted into incorrect array data offset for reference types. Use non-generic one instead. - Add array covariance checks to guarantee type safety.
| @@ -43,6 +49,12 @@ public Span(T[] array, int start, int length) | |||
| if ((uint)start >= (uint)array.Length || (uint)length > (uint)(array.Length - start)) | |||
| ThrowHelper.ThrowArgumentOutOfRangeException(); | |||
|
|
|||
| if (default(T) == null) // Arrays of valuetypes are nnever covariant | |||
There was a problem hiding this comment.
Fixed in #6959. Thanks for taking a look!
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Oct 29, 2016
- Generic ArrayPinningHelper resulted into incorrect array data offset for reference types. Use non-generic one instead. - Add array covariance checks to guarantee type safety.
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Oct 29, 2016
- Generic ArrayPinningHelper resulted into incorrect array data offset for reference types. Use non-generic one instead. - Add array covariance checks to guarantee type safety.
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Oct 29, 2016
- Generic ArrayPinningHelper resulted into incorrect array data offset for reference types. Use non-generic one instead. - Add array covariance checks to guarantee type safety.
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Oct 29, 2016
- Generic ArrayPinningHelper resulted into incorrect array data offset for reference types. Use non-generic one instead. - Add array covariance checks to guarantee type safety.
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Oct 31, 2016
- Generic ArrayPinningHelper resulted into incorrect array data offset for reference types. Use non-generic one instead. - Add array covariance checks to guarantee type safety.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.