Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

ARM64: Change the fixed return buffer argument to be handled as a non-standard argument #5940

Merged
merged 3 commits into from
Jun 24, 2016

Conversation

briansull
Copy link

We already have support for the handling of non-standard arguments and
it is simpler and better to handle the fixed return buffer argument as a non-standard argument.

…standard argument

We already have support for the handling of non-standard arguments and
it is simpler and better to handle the fixed return buffer argument as a non-standard argument.
@briansull
Copy link
Author

@dotnet-bot test Windows_NT arm64 Checked

@briansull
Copy link
Author

@dotnet-bot test Windows_NT arm64 Checked pri1r2r

@briansull briansull changed the title ARM64: Change the fixed return buffer argument to be handled as a non-standard argument [WIP] Change the fixed return buffer argument to be handled as a non-standard argument Jun 23, 2016
@briansull
Copy link
Author

@dotnet-bot test Windows_NT arm64 Checked

@briansull
Copy link
Author

@dotnet-bot test Windows_NT arm64 Checked pri1r2r

@briansull briansull changed the title [WIP] Change the fixed return buffer argument to be handled as a non-standard argument ARM64: Change the fixed return buffer argument to be handled as a non-standard argument Jun 23, 2016
@briansull
Copy link
Author

@BruceForstall PTAL
@dotnet/jit-contrib PTAL
@dotnet/arm64-contrib PTAL

@kyulee1
Copy link

kyulee1 commented Jun 24, 2016

LGTM

@briansull
Copy link
Author

Random comment

@mmitche
Copy link
Member

mmitche commented Jun 24, 2016

@briansull What actually most likely happened here is that since the triggers have been modified a bunch, when you commented the random comment, it went back and checked previous comments for arm64 phrases. It found one and launched.

@briansull
Copy link
Author

Actually I noticed that the two Arm32 jobs (which are new) were running after Kylee1 commented.
However since they are so quick they were finishing up, so since I had already sent email to you.
I added the Random Comment, but they did not restart. So I believe that you are correct.

@briansull briansull merged commit 4fb8970 into dotnet:master Jun 24, 2016
@briansull briansull deleted the retbuf-nonstandard branch June 24, 2016 18:18
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
ARM64: Change the fixed return buffer argument to be handled as a non-standard argument

Commit migrated from dotnet/coreclr@4fb8970
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants