Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

ARM-CI: Convert Linux ARM emulator CI check to cross build (fixes PR #5680) #5786

Merged
merged 1 commit into from
Jun 15, 2016
Merged

ARM-CI: Convert Linux ARM emulator CI check to cross build (fixes PR #5680) #5786

merged 1 commit into from
Jun 15, 2016

Conversation

prajwal-aithal
Copy link

ARM-CI: Convert Linux ARM emulator CI check to cross build (fixes PR #5680)

Signed-off-by: Prajwal A N an.prajwal@samsung.com

@prajwal-aithal
Copy link
Author

@jashook @mmitche @wtgodbe I have made a new PR (identical to PR #5680 ) with the environment variable error fixed.

Summary of changes from PR #5680 are

  • armarmemul_path and armrootfs_mountpath are now declared as groovy variables (instead of bash shell variables)
  • The above groovy variables are used in the build commands using groovy string interpolation (${})
  • The $LINUX_ARM_INCPATH and $LINUX_ARM_CXXFLAGS environment variables are used in the build commands with the $ escaped (need comments on correctness of this change). I am assuming that the previous error was due to groovy parsing the $ symbol according to its string interpolation rules, and that the commands in the exact string form will be executed on the bash shell.

Could you please review this PR and confirm if the above summarized changes fixes the errors caused by PR #5680 ?

cc: @leemgs

@jashook
Copy link

jashook commented Jun 14, 2016

@dotnet-bot test CI Please

…5680)

* Previously used emulated build took a lot of time leading to timeout errors
* Changing this CI check to build using cross build
* Resolves CI issues caused by previous identical PR #5680

Signed-off-by: Prajwal A N <an.prajwal@samsung.com>
@prajwal-aithal
Copy link
Author

@jashook The previous version of this PR was breaking the CI test due to the assert condition to test if the configuration that is being built was one of either Debug or Release. I have changed this check to an if condition (breaking if the configuration is neither of the two).

@prajwal-aithal
Copy link
Author

@dotnet-bot test CI please

@wtgodbe
Copy link
Member

wtgodbe commented Jun 14, 2016

Thanks for doing this! Everything looks good to me (I believe escaping the $ before $LINUX_ARM_INCPATH was the right thing to do, but you might want to get a second opinion on this one. The CI test passing is a pretty good indicator that it was correct, though).

@prajwal-aithal
Copy link
Author

@jashook Can we merge this?

@jashook
Copy link

jashook commented Jun 15, 2016

lgtm

@jashook jashook merged commit ab4cc73 into dotnet:master Jun 15, 2016
@prajwal-aithal prajwal-aithal deleted the devel/arm-ci-cross-build-fix branch June 23, 2016 00:22
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…ci-cross-build-fix

ARM-CI: Convert Linux ARM emulator CI check to cross build (fixes PR dotnet/coreclr#5680)

Commit migrated from dotnet/coreclr@ab4cc73
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants