Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

ARM-CI: Mount Linux ARM emulator rootfs during each build #5209

Merged
merged 1 commit into from
May 25, 2016
Merged

ARM-CI: Mount Linux ARM emulator rootfs during each build #5209

merged 1 commit into from
May 25, 2016

Conversation

prajwal-aithal
Copy link

Signed-off-by: Prajwal A N an.prajwal@samsung.com

* Previous PR #4141 assumed that the rootfs is mounted
  throughout the lifespan of the CI machine
* Changing this to mount and unmount everytime a build is triggered

Signed-off-by: Prajwal A N <an.prajwal@samsung.com>
@prajwal-aithal
Copy link
Author

@jashook
Copy link

jashook commented May 25, 2016

@dotnet-bot test ci please

@jashook
Copy link

jashook commented May 25, 2016

Lgtm

@prajwal-aithal
Copy link
Author

@jashook Does asking dotnet-bot to test CI test the manual jobs as well (Linux ARM emulator build is right now a manually triggered job)?

@prajwal-aithal
Copy link
Author

@jashook Can we merge this to check if the ARM emulator build works correctly?

PS: The 2 CI check failures are not related to my change (they occur due to the absence of a dll file).

@mmitche
Copy link
Member

mmitche commented May 25, 2016

LGTM

@mmitche mmitche merged commit dfdb63b into dotnet:master May 25, 2016
@prajwal-aithal
Copy link
Author

@dotnet-bot test Linux ARM emulator build

@prajwal-aithal
Copy link
Author

@jashook @mmitche When will the new CI script (including the changes of this PR) be in circulation within the CI system?

I tried triggering the Linux ARM emulator build on PR #5211 , but according to the logs of the build here, the contents of this PR are not yet added to the CI script.

@jashook
Copy link

jashook commented May 26, 2016

@jashook
Copy link

jashook commented May 26, 2016

It looks like the unmount command failed so the entire build stopped and got marked as a failure? @mmitche this sound correct?

@prajwal-aithal
Copy link
Author

@jashook @mmitche My bad. I did not think much of what happens to the whole build when a build command fails. We can fix this by changing the line dealing with mounting to
if grep -qs '/opt/linux-arm-emulator-root' /proc/mounts; then sudo umount /opt/linux-arm-emulator-root; fi ; sudo mount /opt/linux-arm-emulator/platform/rootfs-t30.ext4 /opt/linux-arm-emulator-root/

I will open a new PR to do this.

@mmitche
Copy link
Member

mmitche commented May 26, 2016

If a single build step fails it will stop the rest of the build (and then execute post-build commands). So you probably want to make sure your unmount command returns 0 or tests for appropriate errors codes. Obviously if it wasn't mounted, umount would fail, but if umount fails for real reasons then we should probalby stop building

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…ci-fix

ARM-CI: Mount Linux ARM emulator rootfs during each build

Commit migrated from dotnet/coreclr@dfdb63b
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Previous PR dotnet/coreclr#5209 did not check if rootfs is mounted before unmounting
* Build fails due to failed command
* Fixing this by unmounting only if rootfs is already mounted

Signed-off-by: Prajwal A N <an.prajwal@samsung.com>


Commit migrated from dotnet/coreclr@c971a45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants