-
Notifications
You must be signed in to change notification settings - Fork 2.7k
ARM-CI: Mount Linux ARM emulator rootfs during each build #5209
Conversation
* Previous PR #4141 assumed that the rootfs is mounted throughout the lifespan of the CI machine * Changing this to mount and unmount everytime a build is triggered Signed-off-by: Prajwal A N <an.prajwal@samsung.com>
@dotnet-bot test ci please |
Lgtm |
@jashook Does asking dotnet-bot to test CI test the manual jobs as well (Linux ARM emulator build is right now a manually triggered job)? |
@jashook Can we merge this to check if the ARM emulator build works correctly? PS: The 2 CI check failures are not related to my change (they occur due to the absence of a dll file). |
LGTM |
@dotnet-bot test Linux ARM emulator build |
It looks like it ran with the changes here: http://dotnet-ci.cloudapp.net/job/dotnet_coreclr/job/master/job/arm_cross_release_ubuntu/673/console |
It looks like the unmount command failed so the entire build stopped and got marked as a failure? @mmitche this sound correct? |
@jashook @mmitche My bad. I did not think much of what happens to the whole build when a build command fails. We can fix this by changing the line dealing with mounting to I will open a new PR to do this. |
If a single build step fails it will stop the rest of the build (and then execute post-build commands). So you probably want to make sure your unmount command returns 0 or tests for appropriate errors codes. Obviously if it wasn't mounted, umount would fail, but if umount fails for real reasons then we should probalby stop building |
…ci-fix ARM-CI: Mount Linux ARM emulator rootfs during each build Commit migrated from dotnet/coreclr@dfdb63b
* Previous PR dotnet/coreclr#5209 did not check if rootfs is mounted before unmounting * Build fails due to failed command * Fixing this by unmounting only if rootfs is already mounted Signed-off-by: Prajwal A N <an.prajwal@samsung.com> Commit migrated from dotnet/coreclr@c971a45
throughout the lifespan of the CI machine
Signed-off-by: Prajwal A N an.prajwal@samsung.com