Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[release/3.1] Update dependencies from dotnet/corefx #28096

Merged
merged 2 commits into from
Sep 19, 2020
Merged

[release/3.1] Update dependencies from dotnet/corefx #28096

merged 2 commits into from
Sep 19, 2020

Conversation

dotnet-maestro[bot]
Copy link

@dotnet-maestro dotnet-maestro bot commented Sep 14, 2020 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/corefx

  • Subscription: afd7026d-5288-4298-7366-08d72a4ce44a
  • Build: 20200910.1
  • Date Produced: 9/10/2020 6:26 PM
  • Commit: fe18c4973e11d3302aa446039705948e95e20fe8
  • Branch: refs/heads/release/3.1

@Anipik Anipik force-pushed the darc-release/3.1-8a5d96a1-2d8e-4d75-8262-88ea7873992b branch 3 times, most recently from 2dee4e4 to 82fe710 Compare September 17, 2020 23:02
@dotnet-maestro @Anipik
Update dependencies from https://github.com/dotnet/corefx build 20200…
0afbe2c 
…910.1

Microsoft.Private.CoreFx.NETCoreApp
 From Version 4.7.0-preview3.19551.4 -> To Version 4.7.0-servicing.20460.1
@Anipik Anipik force-pushed the darc-release/3.1-8a5d96a1-2d8e-4d75-8262-88ea7873992b branch from 82fe710 to bf5962d Compare September 18, 2020 00:06
@Anipik
Copy link

Anipik commented Sep 18, 2020

@tommcdon @jkoritzinsky can you take a look at the failures in this one ?

@tommcdon
Copy link
Member

@hoyosjs

@Anipik Anipik force-pushed the darc-release/3.1-8a5d96a1-2d8e-4d75-8262-88ea7873992b branch from bf5962d to 854bfc8 Compare September 18, 2020 19:36
@Anipik Anipik requested a review from hoyosjs September 18, 2020 21:38
@hoyosjs
Copy link
Member

hoyosjs commented Sep 18, 2020

Any reason to pin the test dependencies?

@Anipik
Copy link

Anipik commented Sep 18, 2020

MicrosoftPrivateCoreFxNETCoreAppVersion is build with every build but rest of these packages are not being built after we have shipped the stable version
Due to which nuget was resolving wrong package in some cases and in some cases it was resolving 5.0 assets.

@Anipik
Copy link

Anipik commented Sep 18, 2020

We are still flowing the original MicrosoftPrivateCoreFxNETCoreAppVersion toolset dependency.

hoyosjs
hoyosjs approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense then. Although not quite sure then how it passed in the past 7 servicing releases...

LGTM if that's the reason. Thanks. We'll have to wait for the CI to finish to confirm.

@Anipik
Copy link

Anipik commented Sep 18, 2020

Makes sense then. Although not quite sure then how it passed in the past 7 servicing releases...

we never flowed the toolset dependencies in the past services. we were using preview versions and they were getting resolved properly. Some of the packages stopped getting build after the stable release

@Anipik
Copy link

Anipik commented Sep 19, 2020

The regex failure is known hence merging this one

@Anipik Anipik merged commit 3fbe134 into release/3.1 Sep 19, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-release/3.1-8a5d96a1-2d8e-4d75-8262-88ea7873992b branch September 19, 2020 18:51
@runfoapp runfoapp bot mentioned this pull request Sep 29, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anipik @tommcdon @hoyosjs