Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Use ValueStringBuilder instead of StringBuidler{Cache} in multiple places #27441

Merged
merged 2 commits into from
Oct 26, 2019
Merged

Use ValueStringBuilder instead of StringBuidler{Cache} in multiple places #27441

merged 2 commits into from
Oct 26, 2019

Conversation

stephentoub
Copy link
Member

Replaces #26934
cc: @benaadams

@stephentoub stephentoub mentioned this pull request Oct 25, 2019
Closed
@benaadams
Copy link
Member

CI checks aren't running?

@stephentoub stephentoub reopened this Oct 25, 2019
GrabYourPitchforks
GrabYourPitchforks reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One area of concern, but otherwise LGTM.

src/System.Private.CoreLib/shared/System/Exception.cs Outdated Show resolved Hide resolved
@stephentoub stephentoub force-pushed the Exceptions-StringBuilderCache branch 2 times, most recently from fb1880a to fda73fb Compare October 26, 2019 00:57
@stephentoub stephentoub force-pushed the Exceptions-StringBuilderCache branch from fda73fb to 631c606 Compare October 26, 2019 01:00
@stephentoub stephentoub merged commit 373a7b2 into dotnet:master Oct 26, 2019
@stephentoub stephentoub deleted the Exceptions-StringBuilderCache branch October 26, 2019 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks left review comments

@benaadams benaadams benaadams approved these changes

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentoub @benaadams @GrabYourPitchforks @jkotas