This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.0] Opt COM methods out of the new Windows instance-method handling #24012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… back the calling convention support change.
jkoritzinsky
requested review from
mmitche,
vatsan-madhavan and
AaronRobinsonMSFT
AaronRobinsonMSFT
approved these changes
Apr 15, 2019
jkotas
approved these changes
Apr 15, 2019
davidwrighton
approved these changes
Apr 15, 2019
|
WPF has confirmed that this fixes the 3 issues they reported. They'd like to do a full test run and sample validation run as well just to make sure everything is good. |
jkoritzinsky
deleted the
com-legacy-windows-instance-method-abi-on-release-3.0
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our users (such as WPF), use a struct to wrap their HRESULT return types on COM members when they use PreserveSig. When we updated CoreCLR to correctly handle the Windows calling convention, we broke this behavior. Additonally, since #23816 didn't make it into release/3.0, this PR also fixes bugs related to enum returns on COM methods, which WPF also found.
Remove calls to tests that were verifying that COM follows the new behavior. (The tests are removed in the PR to master)
The release/3.0 side of #23974