This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fixing the float/double parsing logic to handle exponents that are too large/small #23043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC. @stephentoub, @danmosemsft The Roslyn RealParser and ES6100M test validation suite both pass under Release. I am also running these under Debug bits but that will take overnight to run. Will be adding a regression test to CoreFX for this scenario. |
stephentoub
reviewed
Mar 6, 2019
| private const int DoubleMinExponent = -324; | ||
|
|
||
| private const int FloatingPointMaxExponent = DoubleMaxExponent; | ||
| private const int FloatingPointMinExponent = DoubleMinExponent; |
There was a problem hiding this comment.
Why do we need these rather than just using DoubleMax/MinExponent?
There was a problem hiding this comment.
It makes it easier to expand to support things like Binary128, if that ever happens.
stephentoub
approved these changes
Mar 6, 2019
These finished without failure as well (and would previously assert all over the place for the given failure case and similar strings). |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…o large/small (dotnet/coreclr#23043) * Fixing the float/double parsing logic to handle exponents that are too large/small * Fixing the debug assert to use >= and <= * Fixing the max exponents to be +1 to match what scale uses. Commit migrated from dotnet/coreclr@5a26509
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves https://github.com/dotnet/corefx/issues/35780