This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove usage of getcontext #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@janvorli Could you please take a look as well? |
|
LGTM, thanks for the unification! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Remove usage of getcontext Commit migrated from dotnet/coreclr@49f5b95
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #2250 contributing to #957 , getting CoreCLR working on platforms using musl and other alternative libc's that do not implemented the deprecated setcontext/getcontext/etc. This does change the meaning of
CONTEXT_GetRegistersasCONTEXT_CaptureContextalready populates anLPCONTEXTso it seems to make more sense to pass that straight toCONTEXT_GetRegisters. I haven't ran the .NET tests against this so I am relying on the CI tests first.