This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commits on Jan 22, 2019
-
Abstract away NOINLINE statement
MSVC and GNU compilers use different attributes for noinline. Abstract away compiler differences.
Configuration menu - View commit details
-
Copy full SHA for 6befc40 - Browse repository at this point
Copy the full SHA 6befc40View commit details -
__cdecl is not defined by default on GNU compilers.
Configuration menu - View commit details
-
Copy full SHA for 12582d3 - Browse repository at this point
Copy the full SHA 12582d3View commit details -
Replace __sync_swap with __atomic_exchange_n
__sync_swap doesn't exist on GNU. Replacing with __atomic_exchange_n which is universally available.
Configuration menu - View commit details
-
Copy full SHA for 1c9f923 - Browse repository at this point
Copy the full SHA 1c9f923View commit details -
Configuration menu - View commit details
-
Copy full SHA for df20217 - Browse repository at this point
Copy the full SHA df20217View commit details -
A pointer value is usually unsigned long on most platforms. Casting it to integer causes signedness issues. Use size_t to be efficient on all 32 and 64 bit architectures.
Configuration menu - View commit details
-
Copy full SHA for 88129ee - Browse repository at this point
Copy the full SHA 88129eeView commit details -
Put quotes around the error string
Correct error statement. GNU G++ is picky about the string following the error statement with ' character in it. It needs to be enclosed with double quotes.
Configuration menu - View commit details
-
Copy full SHA for 6a5e36c - Browse repository at this point
Copy the full SHA 6a5e36cView commit details -
Seeing these warnings with GNU G++ compiler src/pal/src/sync/cs.cpp: In function ‘void CorUnix::InternalInitializeCriticalSectionAndSpinCount(PCRITICAL_SECTION, DWORD, bool)’: src/pal/src/sync/cs.cpp:630:48: warning: converting to non-pointer type ‘SIZE_T {aka long unsigned int}’ from NULL [-Wconversion-null] pPalCriticalSection->OwningThread = NULL; ^ src/pal/src/sync/cs.cpp: In function ‘void CorUnix::InternalLeaveCriticalSection(CorUnix::CPalThread*, _CRITICAL_SECTION*)’: src/pal/src/sync/cs.cpp:880:43: warning: converting to non-pointer type ‘SIZE_T {aka long unsigned int}’ from NULL [-Wconversion-null] pPalCriticalSection->OwningThread = NULL; ^
Configuration menu - View commit details
-
Copy full SHA for bc0f6f3 - Browse repository at this point
Copy the full SHA bc0f6f3View commit details
Commits on Jan 30, 2019
-
Abstract optnone compiler attribute
GNU compiler doesn't support optnone attribute. pal/src/exception/seh-unwind.cpp:449:77: warning: ‘optnone’ attribute directive ignored [-Wattributes]
Configuration menu - View commit details
-
Copy full SHA for ddf89fa - Browse repository at this point
Copy the full SHA ddf89faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42a8d7c - Browse repository at this point
Copy the full SHA 42a8d7cView commit details -
Make __rotl and __rotr functions portable
GNU compiler doesn't have an intrinsic for these. Open code them using the provided implementation.
Configuration menu - View commit details
-
Copy full SHA for aa6c7ef - Browse repository at this point
Copy the full SHA aa6c7efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f324d6 - Browse repository at this point
Copy the full SHA 0f324d6View commit details -
/usr/include/string.h:43:28: error: declaration of ‘void* memcpy(void*, const void*, size_t) throw ()’ has a different exception specifier size_t __n) __THROW __nonnull ((1, 2));
Configuration menu - View commit details
-
Copy full SHA for 657f85b - Browse repository at this point
Copy the full SHA 657f85bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.