This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix directory casing of `regressions' in test/src #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had both tests/src/Regressions and tests/src/regressions which causes problems because the on disc casing of files now differs based on if you have a case insensitive file system or not. This was confusing the the mirror a great deal because the casing of the files is unified on the TFS side but the mirror was seeing these files as renames.
|
/cc @stephentoub @joshfree Can you please take a look? There is no difference in any of the tests, just updating file casing in Git. |
|
LGTM |
|
LGTM. GitHub does a nice job showing the file name changes by clicking on the "showing 237 files changed" link. |
|
|
ellismg
added a commit
that referenced
this pull request
Oct 22, 2015
Fix directory casing of `regressions' in test/src
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix directory casing of `regressions' in test/src Commit migrated from dotnet/coreclr@57b13a9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had both tests/src/Regressions and tests/src/regressions which causes
problems because the on disc casing of files now differs based on if you
have a case insensitive file system or not.
This was confusing the the mirror a great deal because the casing of the
files is unified on the TFS side but the mirror was seeing these files
as renames.