Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[Arm64] Set compFloatingPointUsed for SIMD HWIntrincsics #18118

Merged
merged 1 commit into from
May 30, 2018

Conversation

sdmaclea
Copy link

No description provided.

@CarolEidt
Copy link

I'm not sure that this takes care of all cases - specifically the Crypto assertion failure, since AFAICT, simdType would not be set for that node, but it does require an internal float register.

Copy link

@briansull briansull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@sdmaclea sdmaclea force-pushed the PR-ARM64-compFloatingPointUsed branch from e078366 to e206476 Compare May 24, 2018 22:49
Copy link

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@CarolEidt
Copy link

@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test

@CarolEidt
Copy link

@jashook @BruceForstall - any idea what's going on with the arm64 testing? I restarted it after it seemed that the ci system was back up, but there are two outstanding jobs that have been going for >15 hours.

@CarolEidt
Copy link

@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test

@CarolEidt CarolEidt merged commit 7fb85cf into dotnet:master May 30, 2018
@sdmaclea sdmaclea deleted the PR-ARM64-compFloatingPointUsed branch June 10, 2021 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants