Fix ARM build break #13932

jkotas · 2017-09-13T04:07:12Z

No description provided.

tarekgh · 2017-09-13T15:25:27Z

@jkotas thanks for fixing this. Why are you marking this as no-merge? do you expect more breaks?

jkotas · 2017-09-13T15:31:06Z

There are more breaks, but they are not related to this. I have removed the no merge label already.

tarekgh · 2017-09-13T18:34:54Z

could you confirm the failures in Windows_NT arm Cross Checked Build and Test are unrelated?

10:33:34  "C:\Users\DDJOIN\arm64_ci\tests\tests\Tests\Core_Root\corerun.exe" mainv1.exe 
10:33:34 Expected: 100
10:33:34 Actual: 3

should we merge this change?

jashook · 2017-09-13T18:48:43Z

These failures were introduced by #13733. @jkotas thank you for fixing this.

jashook · 2017-09-13T18:49:30Z

/cc @dotnet/arm32-contrib

hqueue · 2017-09-14T00:08:02Z

It is surprising this bug was still alive.

Thanks for the fix. :)

Fix ARM build break

ef1cfa5

dnfclas added the cla-already-signed label Sep 13, 2017

jkotas mentioned this pull request Sep 13, 2017

Re-implemented the ecvt function. #12894

Merged

jkotas force-pushed the arm-break branch from ef1cfa5 to 4d7f650 Compare September 13, 2017 06:53

jkotas added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 13, 2017

jkotas force-pushed the arm-break branch from 4d7f650 to ef1cfa5 Compare September 13, 2017 15:08

jkotas removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 13, 2017

jashook mentioned this pull request Sep 13, 2017

Fix potentially unused variable in lb arm #13943

Merged

jkotas merged commit c41e519 into dotnet:master Sep 13, 2017

jkotas deleted the arm-break branch September 14, 2017 07:33

Provide feedback